Subject: Re: the ReportScriptingMojo
To: Kartik Ohri <kartikohri13@gmail.com>
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F230337.3040406@anastigmatix.net>
 <CAASLQ4Ny+VWWH=_AR+=7gjXinUScybraOJxBUaG5AmLZmx+NPQ@mail.gmail.com>
 <5F232EBB.9030208@anastigmatix.net>
 <CAASLQ4OknEQTpSeoBfyAZR1na-EyL+AtN9t0fPGyv5DfWJOSWA@mail.gmail.com>
 <CAASLQ4NHROvOq-rUz6Jn0dUd7oAq3_P655WNeqKksNBqFtAGgw@mail.gmail.com>
 <CAASLQ4OCLUYXpkk0tTioz8=zc4UEbAm-Whgp_5K7uy-5hZdjKA@mail.gmail.com>
 <5F278CCE.1090006@anastigmatix.net>
 <CAASLQ4M8cN20L7cyVEgks9qdnfsXH4ci7iQbmyi4v_y0W85eLA@mail.gmail.com>
 <5F2897AF.9040909@anastigmatix.net>
 <CAASLQ4MLFnD3v_fqrUj+Bwc9MSBG-ATet3J7UXebzXHTH_si3A@mail.gmail.com>
 <5F2A29E4.2000803@anastigmatix.net>
 <CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com>
 <5F2EB313.8090706@anastigmatix.net>
 <CAASLQ4M0uvNj0EyMWWNsizT1KtnWx0WFbk89ud9EVHZbu12LMg@mail.gmail.com>
 <5F2EC4F4.3080608@anastigmatix.net>
 <CAASLQ4M3pR+ZL+uPvcQ-dAEL2KdH_PGe-_pBhsjvOgN5qvf+aA@mail.gmail.com>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5F31EFEC.1080609@anastigmatix.net>
Date: Mon, 10 Aug 2020 21:10:04 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: 
 <CAASLQ4M3pR+ZL+uPvcQ-dAEL2KdH_PGe-_pBhsjvOgN5qvf+aA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/10/20 16:55, Kartik Ohri wrote:
> I have pushed the changes adding these two methods. Please take a look and
> let me know if any changes are needed.

Thanks! I added some comments on the github commitdiff.

I also think we should not forget to eventually turn various
catch ( ... e ) { e.printStackTrace(); } places into logged Maven errors.
It would not be nice to have failures get only printed and ignored.
I think the Maven log methods will accept a throwable, and will print
the stacktrace if mvn was run with -e.

Another option would be to wrap it in some unchecked exception, and
catch and unwrap it at some caller that is declared to throw
MojoExecutionException or MavenReportException, then wrap it in one
of those.

One thing I should have warned you about when you were git rebasing: the
commit that's now f96fc90 contains, in its comment, a reference to the
commit that used to be 1d9752b (but is now 037b518, because rebasing
changes commit ids). It still looks like a working link because the old
commit exists in your repository, but it might not get copied into clones.

So if you could do a git rebase -i edb4379 and then (r)eword the comment
for (Try to) link -api from -examples..., changing the reference 1d9752b
to be 037b518, that would be fixed. I don't see any other commit id
references in the subsequent commits.

Regards,
-Chap