Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6Kpq-0005yC-9v for pljava-dev@arkaria.postgresql.org; Thu, 13 Aug 2020 21:32:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k6Kpp-00082E-4d for pljava-dev@arkaria.postgresql.org; Thu, 13 Aug 2020 21:32:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6Kpo-000827-LU for pljava-dev@lists.postgresql.org; Thu, 13 Aug 2020 21:32:29 +0000 Received: from anastigmatix.net ([68.171.219.55]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6Kpi-0002eF-7v for pljava-dev@lists.postgresql.org; Thu, 13 Aug 2020 21:32:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=anastigmatix.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0oYpjbQizowEGM+QWQM01PZJnheV0ji5RHWxSlA61mI=; b=phAe9lXL9qmvCqJujFN3NYf02t kMJqDRekra/1bdPwGpmBMYKBQ6lBYOxp8oVKvYUYdxn2qBaZFbX5tCiyZIMkY+hf+bc0vmqLxkv5l 2RWoIvxGpLukqyEyxphtRmbRdhShyQny7VfWGUOmOKvv+Osecyzglcmi6NOIDAI3dZhXBZ0UoUJCz xrMtDeSyo/qFre4/7+yTZztV06P8CGCyOJw0PIIRs3WZU3aHKJmUf5vW3d4GAaCse8JNzJiv9JGOU aXoYHvoAL9TGg7YWN5GcD04/5Uq2g0lvavuM36ERnPZa5+HnqGKi1mgukACR68HyVBwSNOB5a8D3o S5vKTVzQ==; Received: from [184.19.31.139] (port=34628) by bay.acenet.us with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1k6Kpg-006vv8-9U; Thu, 13 Aug 2020 17:32:20 -0400 Subject: Re: PL/Java new build plugin To: Kartik Ohri References: <5F278CCE.1090006@anastigmatix.net> <5F2897AF.9040909@anastigmatix.net> <5F2A29E4.2000803@anastigmatix.net> <5F2EB313.8090706@anastigmatix.net> <5F2EE97B.1030108@anastigmatix.net> <5F30B425.4020402@anastigmatix.net> <5F331877.50407@anastigmatix.net> <5F3323A6.3050202@anastigmatix.net> Cc: pljava-dev@lists.postgresql.org From: Chapman Flack Message-ID: <5F35B163.2080005@anastigmatix.net> Date: Thu, 13 Aug 2020 17:32:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-96.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bay.acenet.us X-AntiAbuse: Original Domain - lists.postgresql.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - anastigmatix.net X-Get-Message-Sender-Via: bay.acenet.us: authenticated_id: chap@anastigmatix.net X-Authenticated-Sender: bay.acenet.us: chap@anastigmatix.net X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 08/13/20 17:24, Kartik Ohri wrote: > I have made the changes to the ProcessBuilder and am now trying to use it > build pljava-so using it. I wanted to ask should the working directory for > the process builder be hard coded as the project's target directory or left > for the user to specify as an argument. Hmm, that's a good question. What if ... instead of script calling new ProcessBuilder(...) to obtain an instance, we provide a method (with the same signature), that calls the constructor and returns a ProcessBuilder with some common defaults already configured? Then the script can just change any bits it wants different from the default. Regards, -Chap