Subject: Re: the ReportScriptingMojo
To: Kartik Ohri <kartikohri13@gmail.com>
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F2A29E4.2000803@anastigmatix.net>
 <CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com>
 <5F2EB313.8090706@anastigmatix.net>
 <CAASLQ4M0uvNj0EyMWWNsizT1KtnWx0WFbk89ud9EVHZbu12LMg@mail.gmail.com>
 <5F2EC4F4.3080608@anastigmatix.net>
 <CAASLQ4M3pR+ZL+uPvcQ-dAEL2KdH_PGe-_pBhsjvOgN5qvf+aA@mail.gmail.com>
 <5F31EFEC.1080609@anastigmatix.net>
 <CAASLQ4NU9v=nuLDG-LneC68LuqKRXchFckU7mCZT9YQDNKqwvg@mail.gmail.com>
 <5F368380.9070203@anastigmatix.net>
 <CAASLQ4NgH+tXbdUSA8xDh2ct3gAS3xa8V7=E0gcYd+d=m8kujw@mail.gmail.com>
 <5F368A99.6070709@anastigmatix.net> <5F36965C.60707@anastigmatix.net>
 <5F3A7DC6.8090905@anastigmatix.net>
 <CAASLQ4PEgo5Nj0EVsOfGoB96dQFXfFYxrrB0rS1wdad7x_E5fA@mail.gmail.com>
 <CAASLQ4OowXOmnbbbT0Wh1ZkB4h=6JQfC61ojmN07EYnO0QCcow@mail.gmail.com>
 <5F3D32E9.80504@anastigmatix.net> <5F3D36BE.70703@anastigmatix.net>
 <5F3D38F8.7050907@anastigmatix.net> <5F3D3A75.5010304@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5F3D3D2E.4070109@anastigmatix.net>
Date: Wed, 19 Aug 2020 10:54:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <5F3D3A75.5010304@anastigmatix.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/19/20 10:43, Chapman Flack wrote:
> ...META-INF/plexus/components.xml

I think my inclination would be to supply such a file with the role-hint
of 'pgxs', and mapping every phase to empty. Then what the plugin does will
be completely determined by what script <execution>s you configure, and
what phases you put them in.

Then the packaging type of pljava-so could be pgxs, and you would simply
specify the <phase> for each <execution> in the pom (as is already done
for the set-properties execution). So, what the plugin does will be
completely determined by what script <execution>s you configure, and
what phases you put them in.

I think I would also change ScriptingMojo to declare COMPILE as its
default phase. The set-properties execution would still specify
initialize as its phase, as it does now, but I think the usual
behavior is if a phase isn't specified, it will be compile.

Regards,
-Chap