Subject: Re: ScriptingMojo Custom Packaging
To: Kartik Ohri <kartikohri13@gmail.com>
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F2EB313.8090706@anastigmatix.net>
 <CAASLQ4M0uvNj0EyMWWNsizT1KtnWx0WFbk89ud9EVHZbu12LMg@mail.gmail.com>
 <5F2EC4F4.3080608@anastigmatix.net>
 <CAASLQ4M3pR+ZL+uPvcQ-dAEL2KdH_PGe-_pBhsjvOgN5qvf+aA@mail.gmail.com>
 <5F31EFEC.1080609@anastigmatix.net>
 <CAASLQ4NU9v=nuLDG-LneC68LuqKRXchFckU7mCZT9YQDNKqwvg@mail.gmail.com>
 <5F368380.9070203@anastigmatix.net>
 <CAASLQ4NgH+tXbdUSA8xDh2ct3gAS3xa8V7=E0gcYd+d=m8kujw@mail.gmail.com>
 <5F368A99.6070709@anastigmatix.net> <5F36965C.60707@anastigmatix.net>
 <5F3A7DC6.8090905@anastigmatix.net>
 <CAASLQ4PEgo5Nj0EVsOfGoB96dQFXfFYxrrB0rS1wdad7x_E5fA@mail.gmail.com>
 <CAASLQ4OowXOmnbbbT0Wh1ZkB4h=6JQfC61ojmN07EYnO0QCcow@mail.gmail.com>
 <5F3D32E9.80504@anastigmatix.net> <5F3D36BE.70703@anastigmatix.net>
 <5F3D38F8.7050907@anastigmatix.net> <5F3D3A75.5010304@anastigmatix.net>
 <5F3D3D2E.4070109@anastigmatix.net>
 <CAASLQ4P-VeZK46t=PvYw0F05AxqG5i80GTwg2LMhCnjC9WzoZA@mail.gmail.com>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5F3F3F41.3070104@anastigmatix.net>
Date: Thu, 20 Aug 2020 23:28:01 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: 
 <CAASLQ4P-VeZK46t=PvYw0F05AxqG5i80GTwg2LMhCnjC9WzoZA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/20/20 13:00, Kartik Ohri wrote:
> I have made these changes
> https://github.com/amCap1712/pljava/commit/14045b10ca1428fc2914440a2220871ac7c9921b
> but the build process fails with this error
> https://gist.github.com/amCap1712/ad9fe94fd9fb6f4ff4f26913a464c226. I
> checked the jar files manually to make sure the file is present in it. The
> pgxs jar is also listed in the lists of url classpaths.

Hmm ... for me it does not even get that far:

[ERROR] Unknown packaging: pgxs @
org.postgresql:pljava-so:[unknown-version],
/var/tmp/nohome/pljava/pljava-so/pom.xml, line 14, column 13

It seems to be an issue similar to what we had with the profiles before,
referring to a plugin that had not yet been built. Perhaps in your case
it got further because the plugin had been built in an earlier step?

This might make the custom-packaging idea unworkable without a multi-step
build, which I would really rather avoid. Maybe the packaging type
for pljava-so should just be changed from nar to whichever of the
predefined packaging types will impose the fewest extraneous expectations.
Maybe that's pom. It only binds two phases and doesn't assume there is
anything to produce besides the pom file, which is already there.
We'll produce the .so or .dll or .bundle also, but Maven doesn't need
to care.

The custom type seemed more satisfying to me, but not if it ties things
in knots.

Regards,
-Chap