Subject: Re: the ScriptingMojo
To: Kartik Ohri <kartikohri13@gmail.com>
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <CAASLQ4OowXOmnbbbT0Wh1ZkB4h=6JQfC61ojmN07EYnO0QCcow@mail.gmail.com>
 <5F3D32E9.80504@anastigmatix.net> <5F3D36BE.70703@anastigmatix.net>
 <5F3D38F8.7050907@anastigmatix.net> <5F3D3A75.5010304@anastigmatix.net>
 <5F3D3D2E.4070109@anastigmatix.net> <5F3D43BD.4020900@anastigmatix.net>
 <5F3DA48D.7090408@anastigmatix.net>
 <CAASLQ4MBWQeFLdAPNcsgcpLyekU5X=ExQUuGgE49AUFdEYJr8g@mail.gmail.com>
 <5F41943D.9080707@anastigmatix.net>
 <CAASLQ4P5oEx0DLoDLEOAkZSwffU2eS2+NKbevgYqpknHGucaTw@mail.gmail.com>
 <5F427604.5010103@anastigmatix.net>
 <CAASLQ4Nr3MPQuZziVU+89ULZ=BgQjaPPnCLsyPR3mhW-eWoOBw@mail.gmail.com>
 <5F42A71F.8000002@anastigmatix.net>
 <CAASLQ4PkP017rtyUswKO_TCiNmnica-nrQHBgggFw-U_9MstUg@mail.gmail.com>
 <5F459B6E.3020803@anastigmatix.net>
 <CAASLQ4P47TNiEsuj3ga-vuYeCSBJZmHrPM-49E-X=0T5RTmhKw@mail.gmail.com>
 <5F45EE7F.5020609@anastigmatix.net>
 <CAASLQ4MH5JaVbrG9O_S+9dnp=tj_8N3jArxxpf-dJD1ezd5SfQ@mail.gmail.com>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5F470163.2080300@anastigmatix.net>
Date: Wed, 26 Aug 2020 20:42:11 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: 
 <CAASLQ4MH5JaVbrG9O_S+9dnp=tj_8N3jArxxpf-dJD1ezd5SfQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/26/20 12:55, Kartik Ohri wrote:
> I have made some progress on the plugin. The Mac OS X configuration is
> working and passing the CI.

This is going to be good. I noticed that a couple of recent spurious
failures in Travis on my branch were because something went wrong
with travis_install_openssl.sh ... in one case, port install openssl
just hung and the job timed out; in another it said "Port openssl not
found".

What's going to be good is I don't even think that should be necessary
at all. The postgresql build being used came from homebrew, not macports,
and the log shows the homebrew package for openssl was installed at the same
time as a dependency. But homebrew's openssl package is "keg-only", which
means the files don't appear in the usual places; you have to specify
their package-specific locations.

That's probably why there seemed to be a problem early on and installing
(another) openssl package from macports seemed to solve it.

But I see that running pg_config of the homebrew-built PostgreSQL
already shows:

CPPFLAGS = ... -I/usr/local/opt/openssl@1.1/include ...
...
LDFLAGS = -L/usr/local/opt/openssl@1.1/lib ...


so as soon as our build is actually using the options from pg_config,
the build should succeed using the expected homebrew openssl package,
and the whole travis_install_openssl.sh script can just go away.

It's nice to see immediate benefits of the work....

Regards,
-Chap