Subject: Re: Travis and AppVeyor continuous integration [Re:
 feature/master/ci]
To: Kartik Ohri <kartikohri13@gmail.com>, thomas@tada.se
References: <5EC17E17.7070002@anastigmatix.net>
 <CAASLQ4Px21jyb2vJYSrjF5P0RqhA-G_DDWR9QHG68r+W+AqbxQ@mail.gmail.com>
 <CAASLQ4NYE-TW6hjbkSOuAY2Z4NM2cYzqSQ9ahO2LAUhdP9axeQ@mail.gmail.com>
 <5ED7E74B.9020800@anastigmatix.net>
 <CAASLQ4Od6-0=3+4ENKh1Z-Wcu5Wir-bwUn_ccO2UCmDhoR4vtQ@mail.gmail.com>
 <5EDA576E.2000204@anastigmatix.net>
 <CAASLQ4OzPwZB6GG_cXNW4WU4zpHa6wm8Q3WRWNv5pZpis+gf3w@mail.gmail.com>
 <5EDBA5D9.8090506@anastigmatix.net>
 <CAASLQ4P8e9XfUh17HFhYE4eMtq5-C4dpHQAX+hCsia-UFNAjtA@mail.gmail.com>
 <5EE7AE8C.2040201@anastigmatix.net>
 <CAASLQ4PoMTiTZUPxTR7VS8LLo9tosAMu-89T5ikWub7VbM+r4Q@mail.gmail.com>
 <5EEA6F85.9040009@anastigmatix.net> <5F063C86.3070301@anastigmatix.net>
 <5F47EB62.2060306@anastigmatix.net>
 <CAASLQ4N6_=u6nbi+0tD8SSCSO0oPjGLMib7n2c2u5=rSKE+MNw@mail.gmail.com>
 <5F4816A0.8020208@anastigmatix.net>
 <CAO5TtCuTyvyUDkY4iNGr-zUYJe6gy9+RmmO7Dm6QiNzL2p8WLA@mail.gmail.com>
 <CAASLQ4NyFGd8J3iUpA3sCnkQ=4JccDjcHC=xrCemq9L4AdK+HQ@mail.gmail.com>
 <5F4A53C3.1040102@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
From: Chapman Flack <chap@anastigmatix.net>
Message-ID: <5F4A9ED8.9090907@anastigmatix.net>
Date: Sat, 29 Aug 2020 14:30:48 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <5F4A53C3.1040102@anastigmatix.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08/29/20 09:10, Chapman Flack wrote:
> Thomas, if their current permission requests, when configured as a
> GitHub App, are as Kartik describes, and can be limited to the PL/Java
> repo only, would that answer your concerns (even if not perfectly,
> perhaps acceptably)?
> 
> It seems to me also that such concerns can have a "duration" dimension:
> if even their more limited, app-based, permissions are not entirely
> satisfactory, perhaps they would be tolerable for a limited period
> (a calendar quarter, perhaps) to immediately reap the benefits of
> Kartik's work while affording time to explore migrating the scripts
> to Github Actions without a rush?


Not having heard back from Thomas yet, I propose the following:

I will merge PR #289. This will bring the current, working Travis and
AppVeyor configurations into the git history. No CI will happen, of course,
before the corresponding apps are set up.

If Thomas is immovably opposed to setting up the apps, even with their
more limited permissions, for one repository only, perhaps for a limited
period, then the working Travis and AppVeyor configurations will be in
the history anyway, and can serve as starting points for GitHub Actions
workflows to be developed as time permits.

In any case, Kartik, once I have merged #289, you will be able to rebase
feature/master/pgxs over master as feature/master/pgxs-2 and make a new
pull request to supersede #291.

This should happen after the problem you just noticed in
getPgConfigPropertyAsList has been fixed (and a unit test added to
keep it fixed), and after adding -Dpljava.libjvmdefault on the mvn
build commands and removing pljava.libjvm_location from the jshell
test scripts, to confirm that the value gets correctly compiled in.
(The tests, of course, will not run in the main repo. but will still
run in yours.)

Regards,
-Chap