Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4PrO-00054l-VH for pljava-dev@arkaria.postgresql.org; Sat, 08 Aug 2020 14:30:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k4PrN-00089a-Hd for pljava-dev@arkaria.postgresql.org; Sat, 08 Aug 2020 14:30:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4PrN-00089C-6N for pljava-dev@lists.postgresql.org; Sat, 08 Aug 2020 14:30:09 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k4PrK-0000fy-KA for pljava-dev@lists.postgresql.org; Sat, 08 Aug 2020 14:30:07 +0000 Received: by mail-ed1-x530.google.com with SMTP id cq28so3110563edb.10 for ; Sat, 08 Aug 2020 07:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=81/C4yLEMockpdaJOXVIVgpKfMc3rZ7qEVKSVP9GpaQ=; b=IT5rKOhqbEWACBYRiLrlitt06g+EDTXlazdEctk+oadhXwEkn/iM+vokPOssoKu4FH PLBZzsrevx9HL3MGxoSUvRtLVIoAm6D8+McKmwee0ifLeiHSsxnOy3vuan0Op6kYM9gb JeYwZGewOCxiYrantQDvU5v682mC3Nx278Rsl5Ntl7H4cI/R2msLkg2oPOgagpa6X7pL 34UWZwZH/b4Lw88jiScz/THiCuo28GQmHk56/pwIgUiRRVg3NpvraY4U0b9iH5WEInF9 zlTeYifguFmd+q//uFdNYDiGqTFL2u2QINgNNFXmikXcY4U0yT12jZd28fTeHRtaiaG2 ykoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=81/C4yLEMockpdaJOXVIVgpKfMc3rZ7qEVKSVP9GpaQ=; b=hFtdgdH3aML9URDhL28+SO5TLhoWO63euWjKcFYe8SZIGt/dT5CLJjN8AGYgs9jBVc 12BvW8MeVFYCQodUUbotd+mYclzSec3EJOyAR8BoCSwS6z4s8MN/WpWMFE/kCNLnipeI 21ZcBAGD6gk3ncOMED8NlZ6EBQAH7RzTr2rWi6YGBkEUaU9pmRgQVRpB4eil2o823OyV oXwZf3Fq587ueafauTc/soWta+0ZkhG/aaiiF/s1dguWBONb6oVhBdHGaoFQOXtr7BHb /ZhMTua92Z304vGV4vc823wCS2WOlgCr9rhZpLv3WW5sspcni0b0OCVBGoZXuWK1AfrS fC7Q== X-Gm-Message-State: AOAM532GmLlFJJO21LByMQUpaw7S828/Th0YTu7pwXMRSnpPmV53Bg7c wQHazXnIMGnyjMFGZW/kBP1y+bnFJebs9dAjGG2g+BJzEmE= X-Google-Smtp-Source: ABdhPJxY7t/DWkSB1wVevzUvMTum/8MectWyelMF6UnGO7JDHHw/APZzZxu502Oa2TsKoiC6lYD8hMTCgN48mSm5jJQ= X-Received: by 2002:a50:fb10:: with SMTP id d16mr13745728edq.134.1596897003841; Sat, 08 Aug 2020 07:30:03 -0700 (PDT) MIME-Version: 1.0 References: <5F22DF79.2090701@anastigmatix.net> <5F230337.3040406@anastigmatix.net> <5F232EBB.9030208@anastigmatix.net> <5F278CCE.1090006@anastigmatix.net> <5F2897AF.9040909@anastigmatix.net> <5F2A29E4.2000803@anastigmatix.net> <5F2EB313.8090706@anastigmatix.net> In-Reply-To: <5F2EB313.8090706@anastigmatix.net> From: Kartik Ohri Date: Sat, 8 Aug 2020 19:59:49 +0530 Message-ID: Subject: Re: PL/Java new build plugin To: Chapman Flack Cc: pljava-dev@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000a82d3905ac5e8ef3" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a82d3905ac5e8ef3 Content-Type: text/plain; charset="UTF-8" On Sat, Aug 8, 2020 at 7:43 PM Chapman Flack wrote: > On 08/08/20 10:00, Kartik Ohri wrote: > > On Wed, Aug 5, 2020 at 9:09 AM Chapman Flack > wrote: > > > >> On 08/04/20 08:07, Kartik Ohri wrote: > >> > >>> how it would work. I did try to go this route but I felt that it was > >>> getting a bit difficult. So, after some thinking I moved the hard coded > >>> values to the default values of the interface and utilised it in the > >> mojo. > >>> This approach worked well and I have pushed the changes. I have also > >> pushed > >>> a working example to test it. Please review it and let me know if > changes > >>> are required. > >> > >> I've created a branch > >> https://github.com/jcflack/pljava/commits/invocable > >> where you can see the way I had in mind for it to work. > >> > >> I took a look and this way seems to be really better than how I had done > > it. Now that I look at it I feel if I had tried harder, I could have made > > it work myself. I'll try harder next time. Thanks for helping with this. > > I'll merge this into my branch and begin work on the nar maven part. > > Works out better than either person working alone. It's nice to have > a collaborator. :) > > After you merge, would you mind creating a new branch name from that > point, before continuing with the nar-maven part? I don't mind if it's > a new name for the nar-maven part, or you keep 'plugin' for that part > and use a new name to point to this reporting part. > > I'll create a new branch for the nar stuff and begin working on that. I think the reporting part will be just about ready for a pull request > soon, so branching will allow us to do that while you continue with > the nar stuff. > > I am still working on one more commit or so to get the relative links > between javadoc for different modules working right. (Javadoc seems to > have a misfeature that interferes; in the published docs on the site, > I only got it working by using absolute URLs instead, to the actual > tada.github.io site, but of course that makes them broken when testing > in a local staging directory, and makes it harder to one day support > publishing docs for > 1 PL/Java version. So I really want to solve > the relative-link problem.) > > Regards, > -Chap --000000000000a82d3905ac5e8ef3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Aug 8, 2020 at 7:43 PM Chapman Fl= ack <chap@anastigmatix.net&= gt; wrote:
On 08/08/20 10:00, Kartik Ohri wrote:
> On Wed, Aug 5, 2020 at 9:09 AM Chapman Flack <chap@anastigmatix.net> wrote:<= br> >
>> On 08/04/20 08:07, Kartik Ohri wrote:
>>
>>> how it would work. I did try to go this route but I felt that = it was
>>> getting a bit difficult. So, after some thinking I moved the h= ard coded
>>> values to the default values of the interface and utilised it = in the
>> mojo.
>>> This approach worked well and I have pushed the changes. I hav= e also
>> pushed
>>> a working example to test it. Please review it and let me know= if changes
>>> are required.
>>
>> I've created a branch
>> https://github.com/jcflack/pljava/commit= s/invocable
>> where you can see the way I had in mind for it to work.
>>
>> I took a look and this way seems to be really better than how I ha= d done
> it. Now that I look at it I feel if I had tried harder, I could have m= ade
> it work myself. I'll try harder next time. Thanks for helping with= this.
> I'll merge this into my branch and begin work on the nar maven par= t.

Works out better than either person working alone. It's nice to have a collaborator. :)

After you merge, would you mind creating a new branch name from that
point, before continuing with the nar-maven part? I don't mind if it= 9;s
a new name for the nar-maven part, or you keep 'plugin' for that pa= rt
and use a new name to point to this reporting part.


I'll create a new branch for the n= ar stuff and begin working on that.=C2=A0

I think the reporting part will be just about ready for a pull request
soon, so branching will allow us to do that while you continue with
the nar stuff.

I am still working on one more commit or so to get the relative links
between javadoc for different modules working right. (Javadoc seems to
have a misfeature that interferes; in the published docs on the site,
I only got it working by using absolute URLs instead, to the actual
tada= .github.io site, but of course that makes them broken when testing
in a local staging directory, and makes it harder to one day support
publishing docs for > 1 PL/Java version. So I really want to solve
the relative-link problem.)

Regards,
-Chap=C2=A0
--000000000000a82d3905ac5e8ef3--