Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5Epm-0007n0-FX for pljava-dev@arkaria.postgresql.org; Mon, 10 Aug 2020 20:55:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k5Epj-0002Oh-Kf for pljava-dev@arkaria.postgresql.org; Mon, 10 Aug 2020 20:55:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5Epj-0002Oa-Cx for pljava-dev@lists.postgresql.org; Mon, 10 Aug 2020 20:55:51 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k5Eph-0006U2-8v for pljava-dev@lists.postgresql.org; Mon, 10 Aug 2020 20:55:50 +0000 Received: by mail-ed1-x533.google.com with SMTP id q4so7408147edv.13 for ; Mon, 10 Aug 2020 13:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d/Xj42QAipRyQWDGYih2UvCusQ4wQmP0Z7bDQoIMW0g=; b=hIyaLoyYTf/IOrnJXK7nwVvLLlu9M0PlzFTWDVng5hepuI+RORoAb1RiKVSDqibcbT vvaHrjyz9MgQNC4Mc2ZFhKsHF6+sii7rzsFdAuhWTfqxSy5iqIRQqO75PrMzDSFP2MoB t8vnd6qHRAa5cvU8Ttb8Pt3Vnpw34zlo9MexQttcsuwxzIOWo5mycPnXAVZoL8JFe+AQ W5kUvxhp2HTZD7o4xVRWVEOIxvaSKi3wGU6xvQl88F9Jbrd8vprZOEbIWTkWBA4d+AKn Y9540wu5W+aOU+TJMSjigVJAhziDRI9O7P7FzMIJPGw1W5yIJzRQ+CDO2LiJiYrnmjqa Sk4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d/Xj42QAipRyQWDGYih2UvCusQ4wQmP0Z7bDQoIMW0g=; b=gK5Q9rSvjbUpZTM7fIrQGbXemtK8dlNJvZDK7A5cLxkxrvIXVTHYWnsXU+DXrEbIpm KdOuE1safKmEFYMhgCOcpUiSIJIQvRaQT2XH1Q0/BGWb+cQis4ml1pLQxXsxMpz/1HXE 3VgqLJTQ0ywNEjYd65S+M3tpMcpaUSuipr3GvSQEFLl76QLUs2jsmWdF4tQ83IJhR6jM 31UksC6r3mRAuBsfohlzfefA8xFvfdpm6nobwBoG5KStsmdtX7dsS6dPKnN1XYQ8gPpo hoPWPbCzfxrOw0FX0d4HcN28Cl7BuGt2F27+Wq/Bt1/81H5gO6tfUVmwwcSOSKGnmCZK egfg== X-Gm-Message-State: AOAM530xqfLv1Eh6eq8f6ZFp+RAApMHLlHziRXxte4VNaI8BeANGhBPr oCkZ81WPJ3fpUk7bbczV2H/RnUTElHHdYhm65vE= X-Google-Smtp-Source: ABdhPJwdPbfR0UJB/2t2g9OO3DOwkSaP4pq7MS3FwFJMYRnW4KXYIF1Gy92ZQ/klsdx8fha7I5fD9a13zAyb4QIdW0c= X-Received: by 2002:a50:ccd1:: with SMTP id b17mr19895578edj.165.1597092946021; Mon, 10 Aug 2020 13:55:46 -0700 (PDT) MIME-Version: 1.0 References: <5F22DF79.2090701@anastigmatix.net> <5F230337.3040406@anastigmatix.net> <5F232EBB.9030208@anastigmatix.net> <5F278CCE.1090006@anastigmatix.net> <5F2897AF.9040909@anastigmatix.net> <5F2A29E4.2000803@anastigmatix.net> <5F2EB313.8090706@anastigmatix.net> <5F2EC4F4.3080608@anastigmatix.net> In-Reply-To: <5F2EC4F4.3080608@anastigmatix.net> From: Kartik Ohri Date: Tue, 11 Aug 2020 02:25:34 +0530 Message-ID: Subject: Re: the ReportScriptingMojo To: Chapman Flack Cc: pljava-dev@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000b8904305ac8c2d47" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b8904305ac8c2d47 Content-Type: text/plain; charset="UTF-8" Hi! I have pushed the changes adding these two methods. Please take a look and let me know if any changes are needed. Thanks. Regards, Kartik > An element is a module if it is a directory and has a module-info.class, > or it is a jar and either contains a module-info.class or has an > Automatic-Module-Name entry in its manifest. > > Such a method would also be a good place for checking that no element > contains pathSeparator as part of its name, as that would lead to a > malformed path, > --000000000000b8904305ac8c2d47 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!
I have pushed the changes adding these two methods= . Please take a look=C2=A0and let me know if any changes are needed.
<= div>Thanks.
Regards,
Kartik
An element is a module if it is a directory and has a module-info.class,=
or it is a jar and either contains a module-info.class or has an
Automatic-Module-Name entry in its manifest.

Such a method would also be a good place for checking that no element
contains pathSeparator as part of its name, as that would lead to a
malformed path,
--000000000000b8904305ac8c2d47--