MIME-Version: 1.0
References: <5EC17E17.7070002@anastigmatix.net>
 <CAASLQ4N0waxE9JKXjcLD=oAYz8NdgVAjBQd7FWGkuCOghFy8ng@mail.gmail.com>
 <5EC66741.4030208@anastigmatix.net>
In-Reply-To: <5EC66741.4030208@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Fri, 22 May 2020 02:55:25 +0530
Message-ID: 
 <CAASLQ4M4rMaL3gi23+jA-sfLU5DbhN+PTr9Jw3YxmTV_0juvbg@mail.gmail.com>
Subject: Re: Starting build-system work (Windows/Mac users please speak up)
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000004ffa9c05a62f272c"
Precedence: bulk

--0000000000004ffa9c05a62f272c
Content-Type: text/plain; charset="UTF-8"

On Thu, May 21, 2020 at 5:04 PM Chapman Flack <chap@anastigmatix.net> wrote:

> On 05/21/20 02:48, Kartik Ohri wrote:
>
> > Should I add checks for a PostgreSQL version from each major version or
> > just for one from the latest major version and the oldest version
> supported
> > ? Like just test with 9.5 and 12.x .
>
> Each major version in the range, as there are often changes from every
> version to the next that require conditional compilation in PL/Java, and
> it is important to make sure that no recent PL/Java change broke any of
> those.
>
> (It is exactly here that CI promises to make the release process for
> PL/Java much less tedious and treacherous.)
>
> A reasonable timeline might be to get both endpoints covered first,
> and then fill in the middle.
>
> > Same question with Java versions. Is
> > testing with Java 9 and Java 14 (the latest java release) is enough ? Or
> > each of java versions in between Java 9 and 14 should be tested as well.
>
> Again, maybe endpoints first, and then middles. Without testing of
> middles, the odd javac bug that appeared in 10 and 11 and was fixed
> in 12 would have been a surprise. [1]
>
> Regards,
> -Chap
>
>
> [1] https://github.com/tada/pljava/commit/c763cee


Please see https://travis-ci.org/github/amCap1712/pljava/builds/689767027 .
I have written a script to add builds for combinations of major versions of
Java and PostgreSQL on macOS. But I think this is an overkill to for all
platforms (even for a single platform). Let me know your thoughts on this
and if any other additions are required to complete the macOS setup. After
this, I will add builds for Linux and at last for Windows.

Some of the build combinations fail intermittently but work just fine when
ran again. It seems to be an error on Travis CI side. I am investigating
the issue and am working to fix it.

--0000000000004ffa9c05a62f272c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, May 21, 2020 at 5:04 PM Chapman F=
lack &lt;<a href=3D"mailto:chap@anastigmatix.net">chap@anastigmatix.net</a>=
&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_=
quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,=
204);padding-left:1ex">On 05/21/20 02:48, Kartik Ohri wrote:<br>
<br>
&gt; Should I add checks for a PostgreSQL version from each major version o=
r<br>
&gt; just for one from the latest major version and the oldest version supp=
orted<br>
&gt; ? Like just test with 9.5 and 12.x .<br>
<br>
Each major version in the range, as there are often changes from every<br>
version to the next that require conditional compilation in PL/Java, and<br=
>
it is important to make sure that no recent PL/Java change broke any of<br>
those.<br>
<br>
(It is exactly here that CI promises to make the release process for<br>
PL/Java much less tedious and treacherous.)<br>
<br>
A reasonable timeline might be to get both endpoints covered first,<br>
and then fill in the middle.<br>
<br>
&gt; Same question with Java versions. Is<br>
&gt; testing with Java 9 and Java 14 (the latest java release) is enough ? =
Or<br>
&gt; each of java versions in between Java 9 and 14 should be tested as wel=
l.<br>
<br>
Again, maybe endpoints first, and then middles. Without testing of<br>
middles, the odd javac bug that appeared in 10 and 11 and was fixed<br>
in 12 would have been a surprise. [1]<br>
<br>
Regards,<br>
-Chap<br>
<br>
<br>
[1] <a href=3D"https://github.com/tada/pljava/commit/c763cee" rel=3D"norefe=
rrer" target=3D"_blank">https://github.com/tada/pljava/commit/c763cee</a></=
blockquote><div><br></div><div>Please see=C2=A0<a href=3D"https://travis-ci=
.org/github/amCap1712/pljava/builds/689767027">https://travis-ci.org/github=
/amCap1712/pljava/builds/689767027</a>=C2=A0. I have written a script to ad=
d builds for combinations of major versions of Java and PostgreSQL on macOS=
. But I think this is an overkill to for all platforms (even for a single p=
latform). Let me know your thoughts on this and if any other additions are =
required to complete the macOS setup. After this, I will add builds for Lin=
ux and at last for Windows.</div><div><br></div><div>Some of the build comb=
inations fail intermittently but work just fine when ran again. It seems to=
 be an error on Travis CI side. I am investigating the issue and am working=
 to fix it.=C2=A0</div></div></div>

--0000000000004ffa9c05a62f272c--