MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F1CE067.2060107@anastigmatix.net>
 <CAASLQ4OZyt3QL5ZCH0JQyZvuOWTEOgOpko4fC+DPDXgJV0HuPw@mail.gmail.com>
 <5F1F88E0.2050305@anastigmatix.net>
 <CAASLQ4PyG-YvKUTYdqfuQW8yGL+t_93b1i2CMTusoYHbZ0ZTMg@mail.gmail.com>
 <CAASLQ4MDUNP_4BAqK7ZtxtqG7ErH6skMKbNRvL0vE58wdRVxiQ@mail.gmail.com>
 <5F20E585.6010703@anastigmatix.net>
 <CAASLQ4PEcB-Rf1-vFtKCLNxVC6YZsSrzRUd_5TXZsPJp74vvcg@mail.gmail.com>
 <CAASLQ4M1dg+z+J44g77cvzSe3y8q01kWbvCcgoyNzA0j=apfAA@mail.gmail.com>
 <5F22DF79.2090701@anastigmatix.net>
 <CAASLQ4POay=ZLsdOb02n6NqwTn7MGyyWQprcCEo2Wm6Y6rStEw@mail.gmail.com>
 <5F230337.3040406@anastigmatix.net>
 <CAASLQ4Ny+VWWH=_AR+=7gjXinUScybraOJxBUaG5AmLZmx+NPQ@mail.gmail.com>
 <5F232EBB.9030208@anastigmatix.net>
 <CAASLQ4OknEQTpSeoBfyAZR1na-EyL+AtN9t0fPGyv5DfWJOSWA@mail.gmail.com>
 <CAASLQ4NHROvOq-rUz6Jn0dUd7oAq3_P655WNeqKksNBqFtAGgw@mail.gmail.com>
 <CAASLQ4OCLUYXpkk0tTioz8=zc4UEbAm-Whgp_5K7uy-5hZdjKA@mail.gmail.com>
 <5F278CCE.1090006@anastigmatix.net>
In-Reply-To: <5F278CCE.1090006@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Tue, 4 Aug 2020 00:55:51 +0530
Message-ID: 
 <CAASLQ4M8cN20L7cyVEgks9qdnfsXH4ci7iQbmyi4v_y0W85eLA@mail.gmail.com>
Subject: Re: PL/Java new build plugin
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000f9f9a605abfe1b44"
Precedence: bulk

--000000000000f9f9a605abfe1b44
Content-Type: text/plain; charset="UTF-8"

>
> I just noticed, comparing to how the current documentation site looks,
> the maven-javadoc-plugin actually doesn't produce a vestigial Doxia
> report containing a link to the javadocs. It somehow arranges for the
> link to the JavaDocs report to go directly to apidocs/index.html.
>
> I'm sorry I hadn't spotted that before. Have you seen how they did that?
> It would be a nicer experience, and maybe would make the scripting shorter
> also. (And eliminate the temptation to write a fluent wrapper around Sink.)
>
I have fixed this. I checked maven javadoc code but there was nothing much
obvious from it. I then compared the project-reports.html file for the
plugins and found what the issue was. Generating the file using sink was
actually wrong and wouldn't have worked anyways. (Not in the current setup
at least.) Further details are in the commit message.

For git commit messages, there's a kind of widely followed but unofficial
> convention to have a top-line summary of no more than 50 characters,
> then a blank line and any further description as paragraphs below that.
>
> I guess it's a little bit official; 'git help commit' mentions it:
>
>   Though not required, it's a good idea to begin the commit message with
>   a single short (less than 50 character) line summarizing the change,
>   followed by a blank line and then a more thorough description. The text
>   up to the first blank line in a commit message is treated as the commit
>   title, and that title is used throughout Git. For example, git-format-
>   patch(1) turns a commit into email, and it uses the title on the
>   Subject line and the rest of the commit in the body.
>
> If you use commandline git commit and it starts up vim, you'll notice
> the first line as you are typing will change color at character 50, just
> as a kind of gentle reminder.
>

I have now configured my IDE so that such issues do not occur in future.

----------------
I have been checking out nar maven plugin's codebase to see how to invoke
the C compiler and so on. It seems that the plugin delegates at least some
parts to ant. It creates a custom task and hooks its adapter for different
os, architecture and linker configurations into it. Do we want to use ant
for that part or follow a direct approach ?

Regards,
Kartik

--000000000000f9f9a605abfe1b44
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">I just noticed, comparing to how the current documentati=
on site looks,<br>
the maven-javadoc-plugin actually doesn&#39;t produce a vestigial Doxia<br>
report containing a link to the javadocs. It somehow arranges for the<br>
link to the JavaDocs report to go directly to apidocs/index.html.<br>
<br>
I&#39;m sorry I hadn&#39;t spotted that before. Have you seen how they did =
that?<br>
It would be a nicer experience, and maybe would make the scripting shorter<=
br>
also. (And eliminate the temptation to write a fluent wrapper around Sink.)=
<br></blockquote><div>I have fixed this. I checked maven javadoc code but t=
here was nothing much obvious from it. I then compared the project-reports.=
html file for the plugins and found what the issue was. Generating the file=
 using sink was actually wrong and wouldn&#39;t have worked anyways. (Not i=
n the current setup at least.) Further details are in the commit message.</=
div><div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
For git commit messages, there&#39;s a kind of widely followed but unoffici=
al<br>
convention to have a top-line summary of no more than 50 characters,<br>
then a blank line and any further description as paragraphs below that.<br>
<br>
I guess it&#39;s a little bit official; &#39;git help commit&#39; mentions =
it:<br>
<br>
=C2=A0 Though not required, it&#39;s a good idea to begin the commit messag=
e with<br>
=C2=A0 a single short (less than 50 character) line summarizing the change,=
<br>
=C2=A0 followed by a blank line and then a more thorough description. The t=
ext<br>
=C2=A0 up to the first blank line in a commit message is treated as the com=
mit<br>
=C2=A0 title, and that title is used throughout Git. For example, git-forma=
t-<br>
=C2=A0 patch(1) turns a commit into email, and it uses the title on the<br>
=C2=A0 Subject line and the rest of the commit in the body.<br>
<br>
If you use commandline git commit and it starts up vim, you&#39;ll notice<b=
r>
the first line as you are typing will change color at character 50, just<br=
>
as a kind of gentle reminder.<br></blockquote><div><br></div><div>I have no=
w configured my IDE so that such issues do not occur in future.</div><div><=
br></div><div>----------------</div><div>I have been checking out nar maven=
 plugin&#39;s=C2=A0codebase to see how to invoke the C compiler and so on. =
It seems that the plugin delegates at least some parts to ant. It creates a=
 custom task and hooks its adapter for different os, architecture and linke=
r configurations into it. Do we want to use ant for that part or follow a d=
irect approach ?</div><div><br></div><div>Regards,</div><div>Kartik</div></=
div></div>

--000000000000f9f9a605abfe1b44--