MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F2EB313.8090706@anastigmatix.net>
 <CAASLQ4M0uvNj0EyMWWNsizT1KtnWx0WFbk89ud9EVHZbu12LMg@mail.gmail.com>
 <5F2EC4F4.3080608@anastigmatix.net>
 <CAASLQ4M3pR+ZL+uPvcQ-dAEL2KdH_PGe-_pBhsjvOgN5qvf+aA@mail.gmail.com>
 <5F31EFEC.1080609@anastigmatix.net>
 <CAASLQ4NU9v=nuLDG-LneC68LuqKRXchFckU7mCZT9YQDNKqwvg@mail.gmail.com>
 <5F368380.9070203@anastigmatix.net>
 <CAASLQ4NgH+tXbdUSA8xDh2ct3gAS3xa8V7=E0gcYd+d=m8kujw@mail.gmail.com>
 <5F368A99.6070709@anastigmatix.net> <5F36965C.60707@anastigmatix.net>
 <5F3A7DC6.8090905@anastigmatix.net>
 <CAASLQ4PEgo5Nj0EVsOfGoB96dQFXfFYxrrB0rS1wdad7x_E5fA@mail.gmail.com>
 <CAASLQ4OowXOmnbbbT0Wh1ZkB4h=6JQfC61ojmN07EYnO0QCcow@mail.gmail.com>
 <5F3D32E9.80504@anastigmatix.net> <5F3D36BE.70703@anastigmatix.net>
 <5F3D38F8.7050907@anastigmatix.net> <5F3D3A75.5010304@anastigmatix.net>
 <5F3D3D2E.4070109@anastigmatix.net> <5F3D43BD.4020900@anastigmatix.net>
 <5F3DA48D.7090408@anastigmatix.net>
In-Reply-To: <5F3DA48D.7090408@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Sun, 23 Aug 2020 00:42:04 +0530
Message-ID: 
 <CAASLQ4MBWQeFLdAPNcsgcpLyekU5X=ExQUuGgE49AUFdEYJr8g@mail.gmail.com>
Subject: Re: the ScriptingMojo
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000b6c6a905ad7c2108"
Precedence: bulk

--000000000000b6c6a905ad7c2108
Content-Type: text/plain; charset="UTF-8"

>
> It might be worthwhile to define an abstract class in Java that has
> the necessary methods; it could also supply some other useful methods
> or default implementations. I think the javascript could then do something
> like:
>
> var platforms = {
>   'Linux': { compile: function(...) { ... }, link: function... },
>   'Windows' : { ... },
>   ...
> }
>
> var impl = new AbstractPGXS(platforms['Linux']);
>
> which would enforce that the needed methods were all present, and the
> ones supplied in Java would be naturally available too. I have not
> tried this out to make sure it does what I expect in both nashorn
> and graal.
>

Hi!
I really like this idea. But I am not sure how to work this out. The main
point of contention is the class type of platforms["Linux"]. I tested with
Nashorn and Graal and printed the class of the object in the constructor.
For nashorn, it is jdk.nashorn.api.scripting.ScriptObjectMirror and for
graal it is com.oracle.truffle.polyglot.PolyglotMap. So, it will require
implementation based handling depending on the Script Engine. That would
probably require having both Nashorn and Graal present as dependencies or
dynamically instantiating implementations which could get messy (or we
could enforce using graal always, but I don't know if that's a good idea).

But I might be missing something or another easy way here. Also, we could
add a javascript function to examine the object runtime and throw an error
with a detailed message if something is incorrect.

Regards,
Kartik

--000000000000b6c6a905ad7c2108
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">It might be worthwhile to define an abstract class in Ja=
va that has<br>
the necessary methods; it could also supply some other useful methods<br>
or default implementations. I think the javascript could then do something<=
br>
like:<br>
<br>
var platforms =3D {<br>
=C2=A0 &#39;Linux&#39;: { compile: function(...) { ... }, link: function...=
 },<br>
=C2=A0 &#39;Windows&#39; : { ... },<br>
=C2=A0 ...<br>
}<br>
<br>
var impl =3D new AbstractPGXS(platforms[&#39;Linux&#39;]);<br>
<br>
which would enforce that the needed methods were all present, and the<br>
ones supplied in Java would be naturally available too. I have not<br>
tried this out to make sure it does what I expect in both nashorn<br>
and graal.<br></blockquote><div><br></div><div>Hi!</div><div>I really like =
this idea. But I am not sure how to work this out. The main point of conten=
tion is the class type of platforms[&quot;Linux&quot;]. I tested with Nasho=
rn and Graal and printed the class of the object in the constructor. For na=
shorn, it is jdk.nashorn.api.scripting.ScriptObjectMirror and for graal it =
is com.oracle.truffle.polyglot.PolyglotMap. So, it will require implementat=
ion based handling depending on the Script Engine. That would probably requ=
ire having both Nashorn and Graal present as dependencies or dynamically=C2=
=A0instantiating implementations which could get messy (or we could enforce=
 using graal always, but I don&#39;t know if that&#39;s a good idea).=C2=A0=
</div><div><br></div><div>But I might be missing something or another easy =
way here. Also, we could add a javascript function to examine the object ru=
ntime and throw an error with a detailed message if something is incorrect.=
</div><div><br></div><div>Regards,</div><div>Kartik</div><div><br></div></d=
iv></div>

--000000000000b6c6a905ad7c2108--