public inbox for [email protected]
help / color / mirror / Atom feedFrom: Kartik Ohri <[email protected]>
To: Chapman Flack <[email protected]>
Cc: [email protected]
Subject: Re: PL/Java new build plugin
Date: Wed, 29 Jul 2020 00:44:07 +0530
Message-ID: <CAASLQ4MDUNP_4BAqK7ZtxtqG7ErH6skMKbNRvL0vE58wdRVxiQ@mail.gmail.com> (raw)
In-Reply-To: <CAASLQ4PyG-YvKUTYdqfuQW8yGL+t_93b1i2CMTusoYHbZ0ZTMg@mail.gmail.com>
References: <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
<[email protected]>
<CAASLQ4Off+PnB8FqKLokKjAkvKbW00=fjH_LxuYJOGp0_C1YAw@mail.gmail.com>
<CAASLQ4PcU=P4ShuMJOEnQj6p7ZU0VcgJ9St6PMpXcNB_1jPQ+w@mail.gmail.com>
<[email protected]>
<CAASLQ4P_v7u5z76XWfPmVeBvQtNdraiN0MmsRRfq-eNh1O1aTA@mail.gmail.com>
<[email protected]>
<CAASLQ4Ouw1hCHVtSC5XG7Fb-GoO0YAf4_PwsQc=22CvEzhQo6g@mail.gmail.com>
<CAASLQ4MfBz2zj5gm-t+OX-8puxJvf8bSneKeUG+NuX=+CbYCLw@mail.gmail.com>
<[email protected]>
<CAASLQ4NkEDo-UAmqSwUTkCdMu+3WedKCfva5gzNTC45YcWEwNA@mail.gmail.com>
<[email protected]>
<CAASLQ4M_f8cYmxfX5Jqgm9AJHsX62_Cc5pvniXjer4jAZOMOBQ@mail.gmail.com>
<CAASLQ4Pcp24U3rkWkGvcidTfCLQEsAE1it7b3Sr_uNbgO3P9kA@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAASLQ4OZyt3QL5ZCH0JQyZvuOWTEOgOpko4fC+DPDXgJV0HuPw@mail.gmail.com>
<[email protected]>
<CAASLQ4PyG-YvKUTYdqfuQW8yGL+t_93b1i2CMTusoYHbZ0ZTMg@mail.gmail.com>
On Tue, Jul 28, 2020 at 11:53 PM Kartik Ohri <[email protected]> wrote:
> On Tue, Jul 28, 2020 at 7:39 AM Chapman Flack <[email protected]>
> wrote:
>
>> On 07/27/20 06:45, Kartik Ohri wrote:
>> > Hi! The initial version of the javadoc mojo is ready. I have pushed the
>> > changes. For now, I have just exposed a function using which arguments
>> > could be added to the javadoc tool. I also wrote some script for making
>> the
>> > tool work. The javadoc tool works for pljava-api but not for pljava. I
>> am
>> > trying to debug this. It also works for PL/Java Examples. I have
>> hardcoded
>>
>> That looks like a good start. I wonder if the explicit start of a
>> subprocess
>> could be replaced with
>> javax.tools.ToolProvider.getSystemDocumentationTool()
>> and the corresponding API.
>>
> I have made the switch from ProcessBuilder to ToolProvider and pushed the
> changes. The usage is fairly simple as only a list of arguments is required
> to be passed to the tool.
>
>> I think that could be simple enough to just directly use from the
>> JavaScript, which would mean the mojo would not have to be called
>> JavadocMojo or have Javadoc-specific functionality built in. It could
>> concentrate on being a plugin that allows scripting of new reports in
>> general to run in the site lifecycle.
>>
> For now, I have kept the procedure the same but using the ToolProvider API
> is indeed very simple and requires only a couple of lines of code. So, we
> can move those entirely to the script and make the mojo completely agnostic
> to what it does as you suggest. I'll try this and let you know how it goes.
>
I tried this and it works well (except for the pljava module which was
anyways crashing in the previous way as well). Please take a look at the
latest changes and let me what other modifications are required.
> > I did not try to go the interface route yet because I am not sure of the
>> > order in which maven calls these methods. Because if maven calls these
>> > methods before the executeReport method it would be of no use.
>>
>> It might (or, then again, might not) work to guard against that concern
>> by factoring some initialization code into a method of its own, to be
>> called from wrappers around the various interface methods.
>>
>> Regards,
>> -Chap
>>
>
view thread (132+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: PL/Java new build plugin
In-Reply-To: <CAASLQ4MDUNP_4BAqK7ZtxtqG7ErH6skMKbNRvL0vE58wdRVxiQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox