MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F0D35BA.30904@anastigmatix.net>
 <CAASLQ4NmornyOW8n-qyneLpDVPgV0Js=+=Eys6bw3Y-ZiVbVjA@mail.gmail.com>
 <CAASLQ4OYvTQL7ssG4=QyEqhaB71=AM-svBUYj3uRdWXWoQgBPw@mail.gmail.com>
 <5F0E3972.5070609@anastigmatix.net> <5F0F2DA2.5090603@anastigmatix.net>
 <CAASLQ4N40xn-0S4Nsy0Ld75=Ny719MPUE7_aRP_5nAcAqkAqoQ@mail.gmail.com>
 <CAASLQ4OiWCQQwYFnxAQBe2dC6Ms803RjCMX-9AC2=1m0ZzeDhA@mail.gmail.com>
 <5F12FF49.6090906@anastigmatix.net> <5F12FF80.5020208@anastigmatix.net>
 <CAASLQ4MqSVnhK_GMgq03HcmOKk7a-v7b4L0yfPbtRO=mpqoQtA@mail.gmail.com>
 <5F1338F8.6030506@anastigmatix.net>
 <CAASLQ4OR8ZD4GRNHVGuTzJp_UP-PAcADxcz=uymiSFPpg8EEHQ@mail.gmail.com>
 <5F135B84.8070302@anastigmatix.net>
 <CAASLQ4O=tYGASWB6F+PTiB2L3RbmHcVX8XAbKHyhwBDOodH1zg@mail.gmail.com>
 <CAASLQ4P=c42e342-1YTTCBxA=CKBH2m=DLJN+ZQb5EJW6MyofQ@mail.gmail.com>
 <CAASLQ4NU3BgfCnVxvAbu9vK9+gtPT87xX1uBj57b0y2J6nxi+Q@mail.gmail.com>
 <5F14C34E.4020704@anastigmatix.net>
 <CAASLQ4PnDvNwJqMXALCbfAasFAXA6U_Yhf_uM6xAhx0XgyybpA@mail.gmail.com>
In-Reply-To: 
 <CAASLQ4PnDvNwJqMXALCbfAasFAXA6U_Yhf_uM6xAhx0XgyybpA@mail.gmail.com>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Tue, 21 Jul 2020 08:30:57 +0530
Message-ID: 
 <CAASLQ4MVCdq4j8oz4gEHue5XNurua=_PV0r7zFdM75L9bf3O=g@mail.gmail.com>
Subject: Re: PL/Java new build plugin
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000d11a5005aaead52d"
Precedence: bulk

--000000000000d11a5005aaead52d
Content-Type: text/plain; charset="UTF-8"

On Tue, Jul 21, 2020 at 8:29 AM Kartik Ohri <kartikohri13@gmail.com> wrote:

> Something isn't quite right about the handling of -Dpljava.libjvmdefault;
>> the C compiler gives syntax errors if I use it (the build succeeds if
>> I don't). Running with -X shows this being passed to the compiler:
>>
>> -DPLJAVA_LIBJVMDEFAULT=${pljava.qlibjvmdefault}
>>
> It is because the plugin is no longer detecting PLJAVA_LIBJVMDEFAULT. I
> did not retain the method to automatically detect the variable and use it
> and set its value. Should we keep it in the configuration block in pom.xml
> since we have exposed the C quoting as well to the script engine or make an
> exception for this to be specified via command line ?
>
To be sure and also to confirm, I didn't misunderstand something, can you
share the configuration block and the maven command you executed ?

--000000000000d11a5005aaead52d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Tue, Jul 21, 2020 at 8:29 AM Kartik Oh=
ri &lt;<a href=3D"mailto:kartikohri13@gmail.com">kartikohri13@gmail.com</a>=
&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_=
quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,=
204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px=
 solid rgb(204,204,204);padding-left:1ex">Something isn&#39;t quite right a=
bout the handling of -Dpljava.libjvmdefault;<br>
the C compiler gives syntax errors if I use it (the build succeeds if<br>
I don&#39;t). Running with -X shows this being passed to the compiler:<br>
<br>
-DPLJAVA_LIBJVMDEFAULT=3D${pljava.qlibjvmdefault}<br></blockquote><div>It i=
s=C2=A0because the plugin is no longer detecting PLJAVA_LIBJVMDEFAULT. I di=
d not retain the method to automatically detect the variable and use it and=
 set its=C2=A0value. Should=C2=A0we keep it in the configuration block in p=
om.xml since we have exposed the C quoting as well to the script engine or =
make an exception for this to be specified=C2=A0via command line ?</div></d=
iv></div></blockquote><div>To be sure and also to confirm, I didn&#39;t mis=
understand something, can you share the configuration block and the maven c=
ommand you executed ?=C2=A0</div></div></div>

--000000000000d11a5005aaead52d--