Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5ZLC-0006Zr-4x for pljava-dev@arkaria.postgresql.org; Tue, 11 Aug 2020 18:49:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k5ZLA-0001f3-Ri for pljava-dev@arkaria.postgresql.org; Tue, 11 Aug 2020 18:49:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5ZLA-0001ew-L3 for pljava-dev@lists.postgresql.org; Tue, 11 Aug 2020 18:49:40 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k5ZL8-00010Z-8U for pljava-dev@lists.postgresql.org; Tue, 11 Aug 2020 18:49:39 +0000 Received: by mail-ej1-x62c.google.com with SMTP id kq25so14231304ejb.3 for ; Tue, 11 Aug 2020 11:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yUeqltN4mU5WRPgq+LNRz2M6B3uaSKjblWO4cmx7x9M=; b=ucxA7lsU89YQ5G9tcQaesVRnPBW9bYxLqol8pqv2YWSJ9ZpLtKSETLNcXUCBt6vGWI 87hIJuw+zgX/9z+Fqz03u3oXkyiarLyaNnOPWPuM9sM6KFGd9/HH11uIgjogWWkokDmk TzwuEETZiHgXvYtFTrxnIoFVaGDZixE1phOdloYsLQqYrMxBbbv60dT7lS8zal4n52Px M/LP7tOQUf9yKo2Fif9/UQC3YDdO+ww4aQ2rP6gh5M/cVLFOP7pOZTzbPX8ZzRwM7hGj vNDFDnw1hNnLYMbpp1GW/88SKfbqy/gqxPc8xE/xUX2iQqlVSn6ozHf4sR8Jsfs1BKfx lmxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yUeqltN4mU5WRPgq+LNRz2M6B3uaSKjblWO4cmx7x9M=; b=JvlSYk7QasGp2GsDJnovhOz2GXc6A7V9kEBpBhpoEUkLM9/EbbP1cMJ5eRjC5qWlZB PiZulLi1AWmmypD9htcinblG9MrSKt0hc5s2Do0N6arA4oSesRYjLuDiCsE5nPg9fzXu bWrngzYO36pN3LcejYn25mW+TeDa7A0IubchFjdVR5rOQe88N8q394H99ptmpXjcm3Sm Z4BRRAEh8//xlhWmOlZhl2tudAczmcbhp9CklEiiAMhky8vPJot7XEpFMKE+Qt55+Obx LLE1ONNmALO+8/WqfyzZVQx2aI02/Z0J16vI0lPm9//fndRUE92XitbeTv3Y1Jeg8HL6 0CgQ== X-Gm-Message-State: AOAM5326k1pDpDtfKuQ2t2W3wEfNhd14dIh8tQEzDJEN+GmcHdUP0NW9 lvtIGtV0SYP37UIjsa0sCDmY0cUUFjZvWNWB+RhuYoOMedo= X-Google-Smtp-Source: ABdhPJzmu6L8rBY853rb5awepjnQ71uuEMwuKgIM+ZjSEbamY1AJ/ruLfcNucduioTItR6xYhktiI4TfMQS5kuJ0KtQ= X-Received: by 2002:a17:906:359b:: with SMTP id o27mr29167967ejb.103.1597171776396; Tue, 11 Aug 2020 11:49:36 -0700 (PDT) MIME-Version: 1.0 References: <5F230337.3040406@anastigmatix.net> <5F232EBB.9030208@anastigmatix.net> <5F278CCE.1090006@anastigmatix.net> <5F2897AF.9040909@anastigmatix.net> <5F2A29E4.2000803@anastigmatix.net> <5F2EB313.8090706@anastigmatix.net> <5F2EE97B.1030108@anastigmatix.net> <5F30B425.4020402@anastigmatix.net> In-Reply-To: <5F30B425.4020402@anastigmatix.net> From: Kartik Ohri Date: Wed, 12 Aug 2020 00:19:23 +0530 Message-ID: Subject: Re: PL/Java new build plugin To: Chapman Flack Cc: pljava-dev@lists.postgresql.org Content-Type: multipart/alternative; boundary="00000000000060a31805ac9e8808" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000060a31805ac9e8808 Content-Type: text/plain; charset="UTF-8" > > ProcessBuilder is already close to a nice-enough interface for constructing > a command to run, but there should probably be a convenience method for > actually running it; that method could take care of the last steps, > setting the I/O redirection, handling the output, checking the exit > status, and so on. > I have currently added this https://github.com/amCap1712/pljava/commit/174dd71365986094a500d6dda4c832de78f90783. Is this fine? I had to change the way error handling worked to avoid creating a new functional interface. --00000000000060a31805ac9e8808 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
ProcessBuilder is already close to a nice-enough interfa= ce for constructing
a command to run, but there should probably be a convenience method for
actually running it; that method could take care of the last steps,
setting the I/O redirection, handling the output, checking the exit
status, and so on.

I have currently add= ed this=C2=A0https://github.com/amCap1712/pljava/commi= t/174dd71365986094a500d6dda4c832de78f90783. Is this fine? I had to chan= ge the way error handling worked to avoid creating a new functional interfa= ce.=C2=A0
--00000000000060a31805ac9e8808--