MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5EF7B265.3060907@anastigmatix.net>
 <CAASLQ4P6vTfRNVnreNp7Su8VmyhA+wKOYDY8iUfa7eSoogFkXA@mail.gmail.com>
 <5EFA6C22.8060006@anastigmatix.net> <5EFC18D9.3090108@anastigmatix.net>
 <CAASLQ4N0KeUx8PaJMKbHWiVtLvBo3QNACdHgOyk72q30976d+g@mail.gmail.com>
 <5EFD41B1.30009@anastigmatix.net>
 <CAASLQ4NvfJz8VQQFU8mKkY4RabiVQesxdbkudk5Cf24Tm9BixQ@mail.gmail.com>
 <5EFE0A4D.8060402@anastigmatix.net>
 <CAASLQ4M3+XNBYiHMg32X6poY25eMbvMC5MHbA48pt30QK8nAww@mail.gmail.com>
 <5F0125BC.5000609@anastigmatix.net>
 <CAASLQ4PtGSS-OP9k_740EBdyT1bVmDi1PUndn1ZNWzyJDRQkMA@mail.gmail.com>
 <5F0172D7.3000708@anastigmatix.net>
In-Reply-To: <5F0172D7.3000708@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Sun, 5 Jul 2020 16:14:08 +0530
Message-ID: 
 <CAASLQ4NXzEttesB48wxD_wvR5_rNDvXZkKCmNELn247+W_vrMw@mail.gmail.com>
Subject: Re: PL/Java new build plugin
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000c3358705a9af70d5"
Precedence: bulk

--000000000000c3358705a9af70d5
Content-Type: text/plain; charset="UTF-8"

>
> DOTALL is the long name of one of those flags (s); the other one (i) is
> CASE_INSENSITIVE. Am I missing where they are being set?

 I saw I had not committed the change. I'll fix it in the next commit.

> Oh, I think I see where that probably is. For some reason, while the
> 'replacement' string in the underlying java.util.regex methods uses
> $1, $2, etc., to refer to captured groups, just to keep things interesting
> the 'replace' attribute in an ant containsregex element uses \1, \2
> instead. I bet if you ran the output through od or the like, you would see
> that the two empty boxes are the byte values 001 and 002, which are what \1
> and \2 in a Java string literal represent.
>
 Thanks. This fixed the issue.

> Have you written out the assumptions that must be true of pg_config's
> output, for parsing it into the separate properties to be reliable?
>
 The only assumption I make is that pg_config prints each variable
separated by the system's file separator.

I have deleted the ant-run code generating the pgsql.properties file and
read the pgxs.properties file generated by PL/Java PGXS plugin. I have set
up the branch with CI and have observed that this is working for Linux and
macOS but failing for Windows. I will try to debug why this fails for
Windows.

--000000000000c3358705a9af70d5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">DOTALL is the long name of one of those flags (s); the o=
ther one (i) is<br>
CASE_INSENSITIVE. Am I missing where they are being set?</blockquote><div>=
=C2=A0I saw I had not committed=C2=A0the change. I&#39;ll fix it in the nex=
t commit.</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Oh, I think I see where that probably is. For some reason, while the<br>
&#39;replacement&#39; string in the underlying java.util.regex methods uses=
<br>
$1, $2, etc., to refer to captured groups, just to keep things interesting<=
br>
the &#39;replace&#39; attribute in an ant containsregex element uses \1, \2=
<br>
instead. I bet if you ran the output through od or the like, you would see<=
br>
that the two empty boxes are the byte values 001 and 002, which are what \1=
<br>
and \2 in a Java string literal represent.<br></blockquote><div>=C2=A0Thank=
s. This fixed the issue.</div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex">Have you written out the assumptions that must be true of pg_config=
9;s<br>
output, for parsing it into the separate properties to be reliable?<br></bl=
ockquote><div>=C2=A0The only assumption I make is that pg_config prints eac=
h variable separated by the system&#39;s file separator.=C2=A0</div><div><b=
r></div><div>I have deleted the ant-run code generating the pgsql.propertie=
s file and read the pgxs.properties file generated by PL/Java PGXS plugin. =
I have set up the branch with CI and have observed that this is working for=
 Linux and macOS but failing for Windows. I will try to debug why this fail=
s for Windows.</div></div></div>

--000000000000c3358705a9af70d5--