MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F3D32E9.80504@anastigmatix.net> <5F3D36BE.70703@anastigmatix.net>
 <5F3D38F8.7050907@anastigmatix.net> <5F3D3A75.5010304@anastigmatix.net>
 <5F3D3D2E.4070109@anastigmatix.net> <5F3D43BD.4020900@anastigmatix.net>
 <5F3DA48D.7090408@anastigmatix.net>
 <CAASLQ4MBWQeFLdAPNcsgcpLyekU5X=ExQUuGgE49AUFdEYJr8g@mail.gmail.com>
 <5F41943D.9080707@anastigmatix.net>
 <CAASLQ4P5oEx0DLoDLEOAkZSwffU2eS2+NKbevgYqpknHGucaTw@mail.gmail.com>
 <5F427604.5010103@anastigmatix.net>
 <CAASLQ4Nr3MPQuZziVU+89ULZ=BgQjaPPnCLsyPR3mhW-eWoOBw@mail.gmail.com>
 <5F42A71F.8000002@anastigmatix.net>
 <CAASLQ4PkP017rtyUswKO_TCiNmnica-nrQHBgggFw-U_9MstUg@mail.gmail.com>
 <5F459B6E.3020803@anastigmatix.net>
 <CAASLQ4P47TNiEsuj3ga-vuYeCSBJZmHrPM-49E-X=0T5RTmhKw@mail.gmail.com>
 <5F45EE7F.5020609@anastigmatix.net>
 <CAASLQ4MH5JaVbrG9O_S+9dnp=tj_8N3jArxxpf-dJD1ezd5SfQ@mail.gmail.com>
 <5F46B70E.6070601@anastigmatix.net> <5F46DC70.1080404@anastigmatix.net>
In-Reply-To: <5F46DC70.1080404@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Thu, 27 Aug 2020 17:22:36 +0530
Message-ID: 
 <CAASLQ4Npudth33qcg8GHaKd0amJ8oSQro_sxgb72VkbkBj+oXQ@mail.gmail.com>
Subject: Re: the ScriptingMojo
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000003a7c1405adda939d"
Precedence: bulk

--0000000000003a7c1405adda939d
Content-Type: text/plain; charset="UTF-8"

On Thu, Aug 27, 2020 at 3:34 AM Chapman Flack <chap@anastigmatix.net> wrote:

> On 08/26/20 15:25, Chapman Flack wrote:
>
> > If the nar-maven-plugin is also generating such files when it uses MSVC
> > to build, then probably it also has some classes to help generating those
> > files (or it uses a dependency that has some classes to help generating
> > those files). It might not be too bad to end up adding that as a
> dependency
> > of the PGXS plugin (added by a profile conditioned on Windows os) in
> order
> > to reuse that part of its code, if it is accessible.
>
> That stuff seems to be here, and accessible:
>
>
> https://maven-nar.github.io/apidocs/com/github/maven_nar/cpptasks/ide/ProjectWriter.html
>
> ... but I have never really watched the nar-maven-plugin closely enough
> on Windows to see if it even creates such a file for pljava, or just passes
> everything on the command line. I don't know enough about MSVC to know if
> the project file is mandatory.
>
> In your commit cb0ceb9 I see that maybe you could get by with only the
> command line.
>
> Of course I would handle the /DNDEBUG, /DWindows, /DWIN32, and
> /DPLJAVA_SO_VERSION=1.6.0-SNAPSHOT by defines.add (without the /D)
> and overriding formatDefines to supply /D rather than -D. And really,
> the PLJAVA_SO_VERSION=project.version should be among the base defines
> supplied to any template.
>
> I would rather have the probing be done in the probe method; it could
> just have an OS name parameter and return a boolean.
>
> "Windows-MinGW-w64" : {
>   probe : function(os) {
>    return os.startsWith('Windows') && System.gete...GW64");
>
> "Windows-MSVC" : {
>   probe : function(os) {
>    return os.startsWith('Windows') && System.gete...VCINSTALLDIR");
>
> or something like that, where the outer container of the templates would
> be a [ ] rather than a { } so there would be a reliable order for probing
> the templates. The driving code could just go down the list calling
> probe(os) until one returned true, and use that one.
>
> Regards,
> -Chap
>

Yes, I am going to incorporate these changes in the configuration block. I
had hardcoded the values for the sake of getting a basic implementation
ready. A basic implementation is ready and now is working on for all
configurations except MinGW with a weird error
https://ci.appveyor.com/project/amCap1712/pljava/builds/34883248/job/0s01axnd9t76o6da
.

It seems there is some issue in linking but the logs do not hint this.
Another possible reason could be the packaging module not being able to
find the .dll. But again no sign of this from the logs. Do you have any
idea about what could be the issue here ?

Thanks
Regards,
Kartik

--0000000000003a7c1405adda939d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Thu, Aug 27, 2020 at 3:34 AM Chapman F=
lack &lt;<a href=3D"mailto:chap@anastigmatix.net" target=3D"_blank">chap@an=
astigmatix.net</a>&gt; wrote:<br></div><div class=3D"gmail_quote"><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">On 08/26/20 15:25, Chapman Flack w=
rote:<br>
<br>
&gt; If the nar-maven-plugin is also generating such files when it uses MSV=
C<br>
&gt; to build, then probably it also has some classes to help generating th=
ose<br>
&gt; files (or it uses a dependency that has some classes to help generatin=
g<br>
&gt; those files). It might not be too bad to end up adding that as a depen=
dency<br>
&gt; of the PGXS plugin (added by a profile conditioned on Windows os) in o=
rder<br>
&gt; to reuse that part of its code, if it is accessible.<br>
<br>
That stuff seems to be here, and accessible:<br>
<br>
<a href=3D"https://maven-nar.github.io/apidocs/com/github/maven_nar/cpptask=
s/ide/ProjectWriter.html" rel=3D"noreferrer" target=3D"_blank">https://mave=
n-nar.github.io/apidocs/com/github/maven_nar/cpptasks/ide/ProjectWriter.htm=
l</a><br>
<br>
... but I have never really watched the nar-maven-plugin closely enough<br>
on Windows to see if it even creates such a file for pljava, or just passes=
<br>
everything on the command line. I don&#39;t know enough about MSVC to know =
if<br>
the project file is mandatory.<br>
<br>
In your commit cb0ceb9 I see that maybe you could get by with only the<br>
command line.<br>
<br>
Of course I would handle the /DNDEBUG, /DWindows, /DWIN32, and<br>
/DPLJAVA_SO_VERSION=3D1.6.0-SNAPSHOT by defines.add (without the /D)<br>
and overriding formatDefines to supply /D rather than -D. And really,<br>
the PLJAVA_SO_VERSION=3Dproject.version should be among the base defines<br=
>
supplied to any template.<br>
<br>
I would rather have the probing be done in the probe method; it could<br>
just have an OS name parameter and return a boolean.<br>
<br>
&quot;Windows-MinGW-w64&quot; : {<br>
=C2=A0 probe : function(os) {<br>
=C2=A0 =C2=A0return os.startsWith(&#39;Windows&#39;) &amp;&amp; System.gete=
...GW64&quot;);<br>
<br>
&quot;Windows-MSVC&quot; : {<br>
=C2=A0 probe : function(os) {<br>
=C2=A0 =C2=A0return os.startsWith(&#39;Windows&#39;) &amp;&amp; System.gete=
...VCINSTALLDIR&quot;);<br>
<br>
or something like that, where the outer container of the templates would<br=
>
be a [ ] rather than a { } so there would be a reliable order for probing<b=
r>
the templates. The driving code could just go down the list calling<br>
probe(os) until one returned true, and use that one.<br>
<br>
Regards,<br>
-Chap<br></blockquote><div><br></div><div>Yes, I am going to incorporate th=
ese changes in the configuration block. I had hardcoded the values for the =
sake of getting a basic implementation ready. A basic implementation is rea=
dy and now is working on for all configurations except MinGW with a weird e=
rror=C2=A0<a href=3D"https://ci.appveyor.com/project/amCap1712/pljava/build=
s/34883248/job/0s01axnd9t76o6da">https://ci.appveyor.com/project/amCap1712/=
pljava/builds/34883248/job/0s01axnd9t76o6da</a>.=C2=A0</div><div><br></div>=
<div>It seems there is some issue in linking but the logs=C2=A0do not hint =
this. Another possible reason could be the packaging module not being able =
to find the .dll. But again no sign of this from the logs. Do you have any =
idea about what could be the issue here ?</div><div><br></div><div>Thanks</=
div><div>Regards,</div><div>Kartik</div></div></div>

--0000000000003a7c1405adda939d--