MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5EF7B265.3060907@anastigmatix.net>
 <CAASLQ4P6vTfRNVnreNp7Su8VmyhA+wKOYDY8iUfa7eSoogFkXA@mail.gmail.com>
 <5EFA6C22.8060006@anastigmatix.net> <5EFC18D9.3090108@anastigmatix.net>
 <CAASLQ4N0KeUx8PaJMKbHWiVtLvBo3QNACdHgOyk72q30976d+g@mail.gmail.com>
 <5EFD41B1.30009@anastigmatix.net>
In-Reply-To: <5EFD41B1.30009@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Thu, 2 Jul 2020 09:45:11 +0530
Message-ID: 
 <CAASLQ4NvfJz8VQQFU8mKkY4RabiVQesxdbkudk5Cf24Tm9BixQ@mail.gmail.com>
Subject: Re: PL/Java new build plugin
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000042467705a96da820"
Precedence: bulk

--00000000000042467705a96da820
Content-Type: text/plain; charset="UTF-8"

>
> A next step could be to keep everything else unchanged, but see if you
>
can eliminate the code in pljava-so/build.xml that writes the
> pgsql.properties file, and the places in pljava-{so,packaging}/pom.xml
> that read that file, and see if everything works with the new plugin
> doing the work of finding the right values and setting those properties.
> That could quickly make pljava-so/build.xml just go away.


I was reading about setting properties in MOJOs and found this detailed
answer <https://stackoverflow.com/a/14727072/5557184>. I think this impacts
how we utilise the plugin. Can you take a look?

--00000000000042467705a96da820
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">A next step could be to keep everything else unchanged, =
but see if you<br></blockquote><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex">
can eliminate the code in pljava-so/build.xml that writes the<br>
pgsql.properties file, and the places in pljava-{so,packaging}/pom.xml<br>
that read that file, and see if everything works with the new plugin<br>
doing the work of finding the right values and setting those properties.<br=
>
That could quickly make pljava-so/build.xml just go away.</blockquote><div>=
=C2=A0</div><div>I was reading about setting properties in MOJOs and found =
this detailed <a href=3D"https://stackoverflow.com/a/14727072/5557184">answ=
er</a>. I think this impacts how we utilise the plugin. Can you take a look=
?</div></div></div>

--00000000000042467705a96da820--