MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F18C58F.8060204@anastigmatix.net>
 <CAASLQ4NkEDo-UAmqSwUTkCdMu+3WedKCfva5gzNTC45YcWEwNA@mail.gmail.com>
 <5F19C36C.70905@anastigmatix.net>
 <CAASLQ4M_f8cYmxfX5Jqgm9AJHsX62_Cc5pvniXjer4jAZOMOBQ@mail.gmail.com>
 <CAASLQ4Pcp24U3rkWkGvcidTfCLQEsAE1it7b3Sr_uNbgO3P9kA@mail.gmail.com>
 <5F1C6F06.2020809@anastigmatix.net> <5F1CE067.2060107@anastigmatix.net>
 <CAASLQ4OZyt3QL5ZCH0JQyZvuOWTEOgOpko4fC+DPDXgJV0HuPw@mail.gmail.com>
 <5F1F88E0.2050305@anastigmatix.net>
 <CAASLQ4PyG-YvKUTYdqfuQW8yGL+t_93b1i2CMTusoYHbZ0ZTMg@mail.gmail.com>
 <CAASLQ4MDUNP_4BAqK7ZtxtqG7ErH6skMKbNRvL0vE58wdRVxiQ@mail.gmail.com>
 <5F20E585.6010703@anastigmatix.net>
 <CAASLQ4PEcB-Rf1-vFtKCLNxVC6YZsSrzRUd_5TXZsPJp74vvcg@mail.gmail.com>
 <CAASLQ4M1dg+z+J44g77cvzSe3y8q01kWbvCcgoyNzA0j=apfAA@mail.gmail.com>
 <5F22DF79.2090701@anastigmatix.net>
 <CAASLQ4POay=ZLsdOb02n6NqwTn7MGyyWQprcCEo2Wm6Y6rStEw@mail.gmail.com>
 <5F230337.3040406@anastigmatix.net>
In-Reply-To: <5F230337.3040406@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Fri, 31 Jul 2020 01:43:41 +0530
Message-ID: 
 <CAASLQ4Ny+VWWH=_AR+=7gjXinUScybraOJxBUaG5AmLZmx+NPQ@mail.gmail.com>
Subject: Re: PL/Java new build plugin
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000add66d05abae4f90"
Precedence: bulk

--000000000000add66d05abae4f90
Content-Type: text/plain; charset="UTF-8"

>
> Likewise, what I was passing to -encoding and -docencoding
>
should probably come from report.getInputEncoding() and
> report.getOutputEncoding(), respectively. All that should
> be straightforward with the report instance exposed.
>
> Hmm, but those encoding methods are protected; the script might not
> have access. Accessible versions might have to be supplied.
>

I saw you had used project.build.sourceEncoding which is the default value
of inputEncoding [1]. Only if this value is null, the getInputEncoding
method returns ReaderFactory.FILE_ENCODING [2]. But since javadoc is not
complaining in the current implementation, the null case does not
apply. So, this will be probably redundant. A similar argument for output
encoding, it uses a different value which can also be interpolated directly
in the pom. Should I still expose public methods calling these ?

[1] :
https://maven.apache.org/shared/maven-reporting-impl/xref/org/apache/maven/reporting/AbstractMavenReport.html#L86
[2] :
https://maven.apache.org/shared/maven-reporting-impl/xref/org/apache/maven/reporting/AbstractMavenReport.html#L303


Regards,
Kartik

--000000000000add66d05abae4f90
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">Likewise, what I was passing to -encoding and -docencodi=
ng<br></blockquote><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
should probably come from report.getInputEncoding() and<br>
report.getOutputEncoding(), respectively. All that should<br>
be straightforward with the report instance exposed.<br>
<br>
Hmm, but those encoding methods are protected; the script might not<br>
have access. Accessible versions might have to be supplied.<br></blockquote=
><div><br></div><div>I<font color=3D"#000000"> saw you had used project.bui=
ld.sourceEncoding which is the default value of inputEncoding [1]. Only if =
this=C2=A0value is null, the getInputEncoding method returns=C2=A0ReaderFac=
tory.FILE_ENCODING [2]. But since javadoc is not complaining in the current=
 implementation, the null case does not apply.=C2=A0So, this will be probab=
ly redundant. A similar argument for output encoding, it uses a different v=
alue which can also be interpolated directly in the pom. Should I still exp=
ose public methods calling these ?</font>=C2=A0</div><div><br></div><div>[1=
] :=C2=A0<a href=3D"https://maven.apache.org/shared/maven-reporting-impl/xr=
ef/org/apache/maven/reporting/AbstractMavenReport.html#L86">https://maven.a=
pache.org/shared/maven-reporting-impl/xref/org/apache/maven/reporting/Abstr=
actMavenReport.html#L86</a></div><div>[2] :=C2=A0<a href=3D"https://maven.a=
pache.org/shared/maven-reporting-impl/xref/org/apache/maven/reporting/Abstr=
actMavenReport.html#L303">https://maven.apache.org/shared/maven-reporting-i=
mpl/xref/org/apache/maven/reporting/AbstractMavenReport.html#L303</a>=C2=A0=
=C2=A0</div><div><br></div><div>Regards,</div><div>Kartik</div></div></div>

--000000000000add66d05abae4f90--