Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8Osc-000165-E4 for pljava-dev@arkaria.postgresql.org; Wed, 19 Aug 2020 14:15:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k8Osb-00081C-DF for pljava-dev@arkaria.postgresql.org; Wed, 19 Aug 2020 14:15:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8Osb-000815-6h for pljava-dev@lists.postgresql.org; Wed, 19 Aug 2020 14:15:53 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k8OsY-0006AC-TS for pljava-dev@lists.postgresql.org; Wed, 19 Aug 2020 14:15:51 +0000 Received: by mail-ed1-x533.google.com with SMTP id i6so18230740edy.5 for ; Wed, 19 Aug 2020 07:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fiQkBSVudLbbc/NkwPmrRfiNHjmVEwjAAvp+ZkZSNPY=; b=tJfI+W5lA3mvj72F24y9h3O7zmT3Z6znf794C/SdOek7dFjLhx9pFaVUsAkvx97oHG x0FGXX1/wjUGmk2i4OHg08mdOsPrVGHFBmDRuqCKXoxGLLntMjIVzR96nSN3UvVV4AE7 YGru0Q9nbL6S7wc5SdG4jkaKkzV3mLjwzy4yqLvtcwgd6fd3pE9upXGu8SSOPDBW0wjw Om9MR70fHre/HY30tmiIJbbBS/XU98q2P092mG5o12mxTIgFdyyJsy4/hMlpk55JXEij RoycYTOUgJJKumZto9YlmlC60JPkaUDRkA5IHZaTkO938AdJpGBm/TdOmlbTbwuktBFN +iWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fiQkBSVudLbbc/NkwPmrRfiNHjmVEwjAAvp+ZkZSNPY=; b=fDmxM95GKbix4ABDOALGrJvmE+60FV/ZfISapQA1GPqBnoYUPlF8NuLSGxqOc5Ir5w wGiOREqZLFsJO9D3eIoT4YraI/0cRDvik8oVq9BC/FD0KvifTLUXlwOhiNA/5AtSEKAc NISRW+wNwIZMLkaM/bIsbfTfUw2XL4kkrNwjIeCnEJY9gnm5n/xHaCRfjBJXkry1NxIM 0J4Ld5UyoBthxnnKijpYg/XPLqz8UeOqH+cv3HL1lz/RqQqXcDvgVjsJUwW8vRUwQFix 8c988ae4TCxrzfxiHzXJZduZRpxFbaJ6jHlGZELDMjTXwoHkyCpre/uQNCbYM7EkckDW l+tg== X-Gm-Message-State: AOAM533hugSUFUVxt2uUuB5alNPDSZ6ulRm1O/OFzfovqWk/+szB8w5i AdLNxMaS+c8pjdKvMm6W1IQQOCnAsUSQyaMf8c8= X-Google-Smtp-Source: ABdhPJzdTpNjVxF0lK0TsDELxLcoudmDK3GNM87XMKPKQQM75gt1+7uY/HNaLF3elSOeaUp6s3CPHoZDJszE1A76vmw= X-Received: by 2002:a50:ccd1:: with SMTP id b17mr24423357edj.165.1597846548342; Wed, 19 Aug 2020 07:15:48 -0700 (PDT) MIME-Version: 1.0 References: <5F2897AF.9040909@anastigmatix.net> <5F2A29E4.2000803@anastigmatix.net> <5F2EB313.8090706@anastigmatix.net> <5F2EC4F4.3080608@anastigmatix.net> <5F31EFEC.1080609@anastigmatix.net> <5F368380.9070203@anastigmatix.net> <5F368A99.6070709@anastigmatix.net> <5F36965C.60707@anastigmatix.net> <5F3A7DC6.8090905@anastigmatix.net> <5F3D32E9.80504@anastigmatix.net> In-Reply-To: <5F3D32E9.80504@anastigmatix.net> From: Kartik Ohri Date: Wed, 19 Aug 2020 19:45:35 +0530 Message-ID: Subject: Re: the ReportScriptingMojo To: Chapman Flack Cc: pljava-dev@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000eb6c2005ad3ba304" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000eb6c2005ad3ba304 Content-Type: text/plain; charset="UTF-8" On Wed, Aug 19, 2020, 7:40 PM Chapman Flack wrote: > On 08/19/20 08:04, Kartik Ohri wrote: > > Can you explain how to approach the jar building steps and how do we want > > to implement it (jar + nars) or a single jar? > > That's easy! :) The nar-maven-plugin builds a jar because that's what > it does. We don't have any use for the jar it builds. > > The only thing produced in that build that we use is the .so (or .dll > or .bundle, depending on your OS). pljava-packaging looks for that file > in pljava-so/target and puts it in the final package jar. > > How's that for saving you some work? > > Regards, > -Chap > That's really nice. I think I probably have all the parts required then for a linux build. I'll completely remove nar maven plugin from the project and test the build. If it works, I'll proceed on removing the hardcoded values and then to other OS support. Thanks. Regards, Kartik > --000000000000eb6c2005ad3ba304 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Aug 19, 2020, 7:40 PM Chapman Flack <chap@anastigmatix.net> wrote:
On 08/19/20 08:04, Kartik Ohri wrote:
> Can you explain how to approach the jar building steps and how do we w= ant
> to implement it (jar + nars) or a single jar?

That's easy! :) The nar-maven-plugin builds a jar because that's wh= at
it does. We don't have any use for the jar it builds.

The only thing produced in that build that we use is the .so (or .dll
or .bundle, depending on your OS). pljava-packaging looks for that file
in pljava-so/target and puts it in the final package jar.

How's that for saving you some work?

Regards,
-Chap

That's really nice. I think I probably have all the parts required= then for a linux build. I'll completely remove nar maven plugin from t= he project and test the build. If it works, I'll proceed on removing th= e hardcoded values and then to other OS support.
Thanks.

Regards,
Kartik
--000000000000eb6c2005ad3ba304--