MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <CAASLQ4MDUNP_4BAqK7ZtxtqG7ErH6skMKbNRvL0vE58wdRVxiQ@mail.gmail.com>
 <5F20E585.6010703@anastigmatix.net>
 <CAASLQ4PEcB-Rf1-vFtKCLNxVC6YZsSrzRUd_5TXZsPJp74vvcg@mail.gmail.com>
 <CAASLQ4M1dg+z+J44g77cvzSe3y8q01kWbvCcgoyNzA0j=apfAA@mail.gmail.com>
 <5F22DF79.2090701@anastigmatix.net>
 <CAASLQ4POay=ZLsdOb02n6NqwTn7MGyyWQprcCEo2Wm6Y6rStEw@mail.gmail.com>
 <5F230337.3040406@anastigmatix.net>
 <CAASLQ4Ny+VWWH=_AR+=7gjXinUScybraOJxBUaG5AmLZmx+NPQ@mail.gmail.com>
 <5F232EBB.9030208@anastigmatix.net>
 <CAASLQ4OknEQTpSeoBfyAZR1na-EyL+AtN9t0fPGyv5DfWJOSWA@mail.gmail.com>
 <CAASLQ4NHROvOq-rUz6Jn0dUd7oAq3_P655WNeqKksNBqFtAGgw@mail.gmail.com>
 <CAASLQ4OCLUYXpkk0tTioz8=zc4UEbAm-Whgp_5K7uy-5hZdjKA@mail.gmail.com>
 <5F278CCE.1090006@anastigmatix.net>
 <CAASLQ4M8cN20L7cyVEgks9qdnfsXH4ci7iQbmyi4v_y0W85eLA@mail.gmail.com>
 <5F2897AF.9040909@anastigmatix.net>
 <CAASLQ4MLFnD3v_fqrUj+Bwc9MSBG-ATet3J7UXebzXHTH_si3A@mail.gmail.com>
 <5F2A29E4.2000803@anastigmatix.net>
In-Reply-To: <5F2A29E4.2000803@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Sat, 8 Aug 2020 19:30:31 +0530
Message-ID: 
 <CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com>
Subject: Re: PL/Java new build plugin
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000b662e405ac5e2568"
Precedence: bulk

--000000000000b662e405ac5e2568
Content-Type: text/plain; charset="UTF-8"

On Wed, Aug 5, 2020 at 9:09 AM Chapman Flack <chap@anastigmatix.net> wrote:

> On 08/04/20 08:07, Kartik Ohri wrote:
>
> > how it would work. I did try to go this route but I felt that it was
> > getting a bit difficult. So, after some thinking I moved the hard coded
> > values to the default values of the interface and utilised it in the
> mojo.
> > This approach worked well and I have pushed the changes. I have also
> pushed
> > a working example to test it. Please review it and let me know if changes
> > are required.
>
> I've created a branch
> https://github.com/jcflack/pljava/commits/invocable
> where you can see the way I had in mind for it to work.
>
> I took a look and this way seems to be really better than how I had done
it. Now that I look at it I feel if I had tried harder, I could have made
it work myself. I'll try harder next time. Thanks for helping with this.
I'll merge this into my branch and begin work on the nar maven part.

> It seems to, although javadoc still seems to be ignoring my
> --show-packages all, as I had noticed before; I still don't know why,
> but I don't think it's the mojo's fault.
>
> Regards,
> -Chap
>
Regards,
Kartik

--000000000000b662e405ac5e2568
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Wed, Aug 5, 2020 at 9:09 AM Chapman Fl=
ack &lt;<a href=3D"mailto:chap@anastigmatix.net">chap@anastigmatix.net</a>&=
gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_q=
uote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,2=
04);padding-left:1ex">On 08/04/20 08:07, Kartik Ohri wrote:<br>
<br>
&gt; how it would work. I did try to go this route but I felt that it was<b=
r>
&gt; getting a bit difficult. So, after some thinking I moved the hard code=
d<br>
&gt; values to the default values of the interface and utilised it in the m=
ojo.<br>
&gt; This approach worked well and I have pushed the changes. I have also p=
ushed<br>
&gt; a working example to test it. Please review it and let me know if chan=
ges<br>
&gt; are required.<br>
<br>
I&#39;ve created a branch<br>
<a href=3D"https://github.com/jcflack/pljava/commits/invocable" rel=3D"nore=
ferrer" target=3D"_blank">https://github.com/jcflack/pljava/commits/invocab=
le</a><br>
where you can see the way I had in mind for it to work.<br>
<br></blockquote><div>I took a look and this way seems to be really better =
than how I had done it. Now that I look at it I feel if I had=C2=A0tried ha=
rder, I could have made it work myself. I&#39;ll try harder next time. Than=
ks for helping with this. I&#39;ll merge this into my branch and begin work=
 on the nar maven part.</div><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1=
ex">
It seems to, although javadoc still seems to be ignoring my<br>
--show-packages all, as I had noticed before; I still don&#39;t know why,<b=
r>
but I don&#39;t think it&#39;s the mojo&#39;s fault.<br>
<br>
Regards,<br>
-Chap<br></blockquote><div>Regards,</div><div>Kartik=C2=A0</div></div></div=
>

--000000000000b662e405ac5e2568--