MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <CAASLQ4PEe0_1dE-iOBv27fX1SUH0=ewDm=6w9chHLjWSAkeNgQ@mail.gmail.com>
 <5F071CFC.9090306@anastigmatix.net>
 <CAASLQ4MLFd6zhoh+sWWz+iu4d8+H2ML+y=kL990k7H=kk74pvA@mail.gmail.com>
 <5F072647.50301@anastigmatix.net>
 <CAASLQ4Ms0QGf-Qh966HrsoaWzwf1SYHZ0WmZHApQePbcyPejCQ@mail.gmail.com>
 <CAASLQ4NFHYH1pfGJtCZDfdcxf_ZzLA+X+ko86vpyRDKVYr489Q@mail.gmail.com>
 <5F0734AD.7060001@anastigmatix.net>
 <CAASLQ4PDcaAJ8fEwXXFW6XPakc7GCNVgPNGCxA8KYMzPDZw4+w@mail.gmail.com>
 <5F077926.2050806@anastigmatix.net>
 <CAASLQ4OuFQCiSMeypQtfRaAvj-4H-EAgszLwdAo6Tc1zS9B66g@mail.gmail.com>
 <5F07C2D5.5050904@anastigmatix.net>
 <CAASLQ4PSizkzBKyyfkp9ccJ1qDPLRLu6g2bo9cN-XuTzGQFGfQ@mail.gmail.com>
 <CAASLQ4P9zGxHda=HAGJ2eAa-oMmJtnPm=4a14mj4P-QpfFsYxg@mail.gmail.com>
 <5F0D35BA.30904@anastigmatix.net>
 <CAASLQ4NmornyOW8n-qyneLpDVPgV0Js=+=Eys6bw3Y-ZiVbVjA@mail.gmail.com>
 <CAASLQ4OYvTQL7ssG4=QyEqhaB71=AM-svBUYj3uRdWXWoQgBPw@mail.gmail.com>
 <5F0E3972.5070609@anastigmatix.net>
 <CAASLQ4P+zUuWvpXb9U_CDY384P=sSNP0ATYCb0nf1d=sbt5TjA@mail.gmail.com>
In-Reply-To: 
 <CAASLQ4P+zUuWvpXb9U_CDY384P=sSNP0ATYCb0nf1d=sbt5TjA@mail.gmail.com>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Wed, 15 Jul 2020 16:57:32 +0530
Message-ID: 
 <CAASLQ4O8NuO_umcCFBOJNUMKfNVrrdBjdDGc3ttpb=L-oOooiA@mail.gmail.com>
Subject: Re: PL/Java new build plugin
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000068a4f805aa79365c"
Precedence: bulk

--00000000000068a4f805aa79365c
Content-Type: text/plain; charset="UTF-8"

>
> Even though pg_config explicitly writes
>> a single \n character on every platform, Windows (probably the C library
>> really) still changes it to \r\n before it arrives on the pipe.
>
> This was indeed the case. I also confirmed with a C dev in ##c and they
said that C changes \n to \r\n on Windows. I have fixed this issue. There
is no longer any include path error. There was another error related nar
maven which I was able to fix by setting PGSQL_PKGLIBDIR in addition to
other variables. The plugin now works on windows as well.

I had suspected the same but didn't test it due to some reason I seem to
> have forgotten but I will do that now.
>
This has been also fixed by replacing PG=9 with PG=9.6. I chose 9.6 because
it is the only 9.x PG available in appveyor. If we want to test against any
other 9.x PG, then we need to install it separately.

--00000000000068a4f805aa79365c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex">Even though pg_config explicitly writ=
es<br>
a single \n character on every platform, Windows (probably the C library<br=
>
really) still changes it to \r\n before it arrives on the pipe.=C2=A0</bloc=
kquote></div></div></blockquote><div>This was indeed the case. I also confi=
rmed with a C dev in ##c and they said that C changes \n to \r\n on Windows=
. I have fixed this issue. There is no longer any include path error. There=
 was another error related nar maven which I was able to fix by setting PGS=
QL_PKGLIBDIR in addition to other=C2=A0variables. The plugin now works on w=
indows as well.</div><div><br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div>I had suspected=
 the same but didn&#39;t test it due to some reason I seem to have forgotte=
n but I will do that now.</div></div></div></blockquote><div>This has been =
also fixed by replacing PG=3D9 with PG=3D9.6. I chose 9.6 because it is the=
 only 9.x PG available in appveyor. If we want to test against any other 9.=
x PG, then we need to install it separately.</div></div></div>

--00000000000068a4f805aa79365c--