MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <CAASLQ4OCLUYXpkk0tTioz8=zc4UEbAm-Whgp_5K7uy-5hZdjKA@mail.gmail.com>
 <5F278CCE.1090006@anastigmatix.net>
 <CAASLQ4M8cN20L7cyVEgks9qdnfsXH4ci7iQbmyi4v_y0W85eLA@mail.gmail.com>
 <5F2897AF.9040909@anastigmatix.net>
 <CAASLQ4MLFnD3v_fqrUj+Bwc9MSBG-ATet3J7UXebzXHTH_si3A@mail.gmail.com>
 <5F2A29E4.2000803@anastigmatix.net>
 <CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com>
 <5F2EB313.8090706@anastigmatix.net> <5F2EE97B.1030108@anastigmatix.net>
 <CAASLQ4NzHE-YO9XYTQSqHEEz9UQm8dRq1d-jbdAFPVATFiLN2w@mail.gmail.com>
 <CAASLQ4OLhgc=MMMOWv2sxt93xC1Te4vwThBgEy7=QBBz0dEn6g@mail.gmail.com>
 <5F30B425.4020402@anastigmatix.net>
 <CAASLQ4NA76safp+fa__9kMo2sG__EiwGdViFECgQ4wfL3=OpXw@mail.gmail.com>
 <5F331877.50407@anastigmatix.net>
 <CAASLQ4O3ONhDr-XgwDDD3oW+x2VwCDTmuu-T+fz-jcZ=T23zuw@mail.gmail.com>
 <5F3323A6.3050202@anastigmatix.net>
 <CAASLQ4NSgCJSziVoAAuaLt0Ed-qEo+As54uXco0PZ65n4f4n5A@mail.gmail.com>
 <5F35B163.2080005@anastigmatix.net>
In-Reply-To: <5F35B163.2080005@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Fri, 14 Aug 2020 08:14:55 +0530
Message-ID: 
 <CAASLQ4OEbbz1D7eH-fHPcSwA2u4cPqUV_=+TXZz4wW+0UWX-Dw@mail.gmail.com>
Subject: Re: PL/Java new build plugin
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000a5f68105accd68cf"
Precedence: bulk

--000000000000a5f68105accd68cf
Content-Type: text/plain; charset="UTF-8"

On Fri, Aug 14, 2020, 3:02 AM Chapman Flack <chap@anastigmatix.net> wrote:

> On 08/13/20 17:24, Kartik Ohri wrote:
> > I have made the changes to the ProcessBuilder and am now trying to use it
> > build pljava-so using it. I wanted to ask should the working directory
> for
> > the process builder be hard coded as the project's target directory or
> left
> > for the user to specify as an argument.
>
> Hmm, that's a good question.
>
> What if ... instead of script calling new ProcessBuilder(...) to obtain
> an instance, we provide a method (with the same signature), that calls
> the constructor and returns a ProcessBuilder with some common defaults
> already configured?
>
> Then the script can just change any bits it wants different from the
> default.
>
> Regards,
> -Chap
>

Sounds good to me. Will do it this way.
Regards,
Kartik

>

--000000000000a5f68105accd68cf
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D=
"gmail_attr">On Fri, Aug 14, 2020, 3:02 AM Chapman Flack &lt;<a href=3D"mai=
lto:chap@anastigmatix.net">chap@anastigmatix.net</a>&gt; wrote:<br></div><b=
lockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px =
#ccc solid;padding-left:1ex">On 08/13/20 17:24, Kartik Ohri wrote:<br>
&gt; I have made the changes to the ProcessBuilder and am now trying to use=
 it<br>
&gt; build pljava-so using it. I wanted to ask should the working directory=
 for<br>
&gt; the process builder be hard coded as the project&#39;s target director=
y or left<br>
&gt; for the user to specify as an argument.<br>
<br>
Hmm, that&#39;s a good question.<br>
<br>
What if ... instead of script calling new ProcessBuilder(...) to obtain<br>
an instance, we provide a method (with the same signature), that calls<br>
the constructor and returns a ProcessBuilder with some common defaults<br>
already configured?<br>
<br>
Then the script can just change any bits it wants different from the<br>
default.<br>
<br>
Regards,<br>
-Chap<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"a=
uto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"=
margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"></blockquote=
></div></div><div dir=3D"auto"><span style=3D"font-family:sans-serif">Sound=
s good to me. Will do it this way.</span><br></div><div dir=3D"auto"><font =
face=3D"sans-serif">Regards,</font></div><div dir=3D"auto"><font face=3D"sa=
ns-serif">Kartik</font></div><div dir=3D"auto"><div class=3D"gmail_quote"><=
blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px=
 #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--000000000000a5f68105accd68cf--