Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k1FZP-0008D7-T1 for pljava-dev@arkaria.postgresql.org; Thu, 30 Jul 2020 20:54:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k1FZN-0004Hh-Mf for pljava-dev@arkaria.postgresql.org; Thu, 30 Jul 2020 20:54:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k1FZN-0004Ha-Et for pljava-dev@lists.postgresql.org; Thu, 30 Jul 2020 20:54:29 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1k1FZK-0007IW-Gf for pljava-dev@lists.postgresql.org; Thu, 30 Jul 2020 20:54:28 +0000 Received: by mail-ej1-x633.google.com with SMTP id f24so8839483ejx.6 for ; Thu, 30 Jul 2020 13:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BLbGquNqKutd23X87k/LBxX2nf1caL2Ojp9ZNVwMRGI=; b=vI3EAoBBn4KD3tJ0wEm89zxK9xuz82a5dGFCv8V8np2kCsq2I2iaSdWonUl7KOodWl 8lC0z9dN0MrVBdCVKaJOZuTJ/SiuOndBYBnlxWg/ql8OUWMbWN8FBhKv4d+v7yjE5CKC 5ydR/4uaQPjm1144c3TsrWCDQFaT7K6kejiWeRefbfda7omaz9E4mmztqj/0XxCdz66f OrmriG6pnaznXLBOYGRjN/ldBL+Iw1n0vGMlQpGSTQkD0KTSk6+2rCvj8ncHcBoPmb7L nHJlWv/s81SxzY2VrDXbCIRRUsPgoPTptXtgPdqT3pM1mFOXh9wIENDDY2w+6I5Wfjwa l1tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BLbGquNqKutd23X87k/LBxX2nf1caL2Ojp9ZNVwMRGI=; b=dE/iGyPSKW0KNLgsnqE1uip5reX6DbJLJinnsZeInfa9e+LqtQqBXvYi74R4XJWxaM dVYD/CAKkGgpcSFclMoeOzNT9T9UPBcGphHb9g2Amczo4wlMDr7KWusee3MoeOIARfgD k72nPc/J4/+Mrc0KXT6a8mpGi5B9QWBXvOVcUn6a1I+slueSEJb51iQh/+6ok/MGF2Zz CS/wDy5euLzOYN6wQNTl0QN47qDdX6avK4N9EcCgBYsMeIjUMVTAb+T7h8xPZl1JX+B4 JjBHxl0EGXH13oPddzyEkUrI+oadnqAaHLzmve9SzSRe0K8MEpX4RJIv5dAgKznLC929 Zvjw== X-Gm-Message-State: AOAM531WegSUWbly/YobaUU1I0nApGwzK8z2kZlbph/hSBuym/TvC1K/ EmQlF/ZMVMUokmrWcFKlM+DK5JeJOfKFmnzmrSg= X-Google-Smtp-Source: ABdhPJxRh0mFd2lQfhAw4aD/lVah/5YekUqTeDKAKCP4pbPZRhbO3QkLQ9nEhXohsrPLBAIxgXXsAPzvYoBpBHWgSl0= X-Received: by 2002:a17:907:4303:: with SMTP id nh3mr951717ejb.520.1596142464367; Thu, 30 Jul 2020 13:54:24 -0700 (PDT) MIME-Version: 1.0 References: <5F19C36C.70905@anastigmatix.net> <5F1C6F06.2020809@anastigmatix.net> <5F1CE067.2060107@anastigmatix.net> <5F1F88E0.2050305@anastigmatix.net> <5F20E585.6010703@anastigmatix.net> <5F22DF79.2090701@anastigmatix.net> <5F230337.3040406@anastigmatix.net> <5F232EBB.9030208@anastigmatix.net> In-Reply-To: <5F232EBB.9030208@anastigmatix.net> From: Kartik Ohri Date: Fri, 31 Jul 2020 02:24:12 +0530 Message-ID: Subject: Re: PL/Java new build plugin To: Chapman Flack Cc: pljava-dev@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000997fcf05abaee080" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000997fcf05abaee080 Content-Type: text/plain; charset="UTF-8" On Fri, Jul 31, 2020 at 2:04 AM Chapman Flack wrote: > On 07/30/20 16:13, Kartik Ohri wrote: > > I saw you had used project.build.sourceEncoding which is the default > value > > of inputEncoding [1]. Only if this value is null, the getInputEncoding > > method returns ReaderFactory.FILE_ENCODING [2]. But since javadoc is not > > complaining in the current implementation, the null case does not > > apply. So, this will be probably redundant. A similar argument for output > > encoding, it uses a different value which can also be interpolated > directly > > in the pom. Should I still expose public methods calling these ? > > As you say, the importance is kind of minor ... but if the effort required > is also minor, it is probably worthwhile, just because it allows a script > snippet to be written in a way that will look 'right' on its face to any > casual reader, who need not know as much of the implementation detail > as you do. Yes, that indeed makes sense :). I have made and pushed the required changes. > > Might be simplest just to override them, loosening the access modifier > to public and calling the super method. As 'this' is already available > to the script, maybe nothing more is needed. > > Regards, > -Chap > Regards, Kartik --000000000000997fcf05abaee080 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Jul 31, 2020 at 2:04 AM Chapman F= lack <chap@anastigmatix.net= > wrote:
On 07/30/20 16:13, Kartik Ohri wrote:
> I saw you had used project.build.sourceEncoding which is the default v= alue
> of inputEncoding [1]. Only if this value is null, the getInputEncoding=
> method returns ReaderFactory.FILE_ENCODING [2]. But since javadoc is n= ot
> complaining in the current implementation, the null case does not
> apply. So, this will be probably redundant. A similar argument for out= put
> encoding, it uses a different value which can also be interpolated dir= ectly
> in the pom. Should I still expose public methods calling these ?

As you say, the importance is kind of minor ... but if the effort required<= br> is also minor, it is probably worthwhile, just because it allows a script snippet to be written in a way that will look 'right' on its face t= o any
casual reader, who need not know as much of the implementation detail
as you do.
Yes, that indeed makes sense :). I have made an= d pushed the required=C2=A0changes.
=C2=A0
Might be simplest just to override them, loosening the access modifier
to public and calling the super method. As 'this' is already availa= ble
to the script, maybe nothing more is needed.

Regards,
-Chap
Regards,
Kartik=C2=A0
--000000000000997fcf05abaee080--