public inbox for [email protected]  
help / color / mirror / Atom feed
From: Kartik Ohri <[email protected]>
To: Chapman Flack <[email protected]>
Cc: [email protected]
Subject: Re: PL/Java new build plugin
Date: Fri, 10 Jul 2020 02:16:41 +0530
Message-ID: <CAASLQ4OuFQCiSMeypQtfRaAvj-4H-EAgszLwdAo6Tc1zS9B66g@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
	<[email protected]>
	<CAASLQ4OCh2ybECbfJQ5UgSo4r-UxRcmPPhqjrGpEZ=ZPdURNMg@mail.gmail.com>
	<[email protected]>
	<CAASLQ4MWn3BjiZpijXEjd3sYaeuQnFffafZYe9XWnV8PPXv1nQ@mail.gmail.com>
	<[email protected]>
	<CAASLQ4NOq2FcTvp1hB-kTnJZgxfRP=u20gfQT=tgpvBq+9Ac-w@mail.gmail.com>
	<CAASLQ4PwL2U6t0DYZK4KF9+2UZT56Npcga4xZWWfo04w2QZxCQ@mail.gmail.com>
	<[email protected]>
	<CAASLQ4PEe0_1dE-iOBv27fX1SUH0=ewDm=6w9chHLjWSAkeNgQ@mail.gmail.com>
	<[email protected]>
	<CAASLQ4MLFd6zhoh+sWWz+iu4d8+H2ML+y=kL990k7H=kk74pvA@mail.gmail.com>
	<[email protected]>
	<CAASLQ4Ms0QGf-Qh966HrsoaWzwf1SYHZ0WmZHApQePbcyPejCQ@mail.gmail.com>
	<CAASLQ4NFHYH1pfGJtCZDfdcxf_ZzLA+X+ko86vpyRDKVYr489Q@mail.gmail.com>
	<[email protected]>
	<CAASLQ4PDcaAJ8fEwXXFW6XPakc7GCNVgPNGCxA8KYMzPDZw4+w@mail.gmail.com>
	<[email protected]>

Thanks for the detailed explanation. Yes, indeed. I had to make minimal
changes in order to get the regex to compile in Java. I'll try to test it.

You review the commit without the regex
https://github.com/amCap1712/pljava/commit/e02a71a0184b70b03b14e54ff454f97dc9946759
here.
The pgxs properties file is still created because it is needed by build.xml
in pljava-packaging. I have not gone into depth of it but I'll take a look
at it soon and try to remove it from there as well.

Regards,
Kartik.


view thread (132+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: PL/Java new build plugin
  In-Reply-To: <CAASLQ4OuFQCiSMeypQtfRaAvj-4H-EAgszLwdAo6Tc1zS9B66g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox