MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <CAASLQ4PEe0_1dE-iOBv27fX1SUH0=ewDm=6w9chHLjWSAkeNgQ@mail.gmail.com>
 <5F071CFC.9090306@anastigmatix.net>
 <CAASLQ4MLFd6zhoh+sWWz+iu4d8+H2ML+y=kL990k7H=kk74pvA@mail.gmail.com>
 <5F072647.50301@anastigmatix.net>
 <CAASLQ4Ms0QGf-Qh966HrsoaWzwf1SYHZ0WmZHApQePbcyPejCQ@mail.gmail.com>
 <CAASLQ4NFHYH1pfGJtCZDfdcxf_ZzLA+X+ko86vpyRDKVYr489Q@mail.gmail.com>
 <5F0734AD.7060001@anastigmatix.net>
 <CAASLQ4PDcaAJ8fEwXXFW6XPakc7GCNVgPNGCxA8KYMzPDZw4+w@mail.gmail.com>
 <5F077926.2050806@anastigmatix.net>
 <CAASLQ4OuFQCiSMeypQtfRaAvj-4H-EAgszLwdAo6Tc1zS9B66g@mail.gmail.com>
 <5F07C2D5.5050904@anastigmatix.net>
 <CAASLQ4PSizkzBKyyfkp9ccJ1qDPLRLu6g2bo9cN-XuTzGQFGfQ@mail.gmail.com>
 <CAASLQ4P9zGxHda=HAGJ2eAa-oMmJtnPm=4a14mj4P-QpfFsYxg@mail.gmail.com>
 <5F0D35BA.30904@anastigmatix.net>
 <CAASLQ4NmornyOW8n-qyneLpDVPgV0Js=+=Eys6bw3Y-ZiVbVjA@mail.gmail.com>
 <CAASLQ4OYvTQL7ssG4=QyEqhaB71=AM-svBUYj3uRdWXWoQgBPw@mail.gmail.com>
 <5F0E3972.5070609@anastigmatix.net>
In-Reply-To: <5F0E3972.5070609@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Wed, 15 Jul 2020 09:00:09 +0530
Message-ID: 
 <CAASLQ4P+zUuWvpXb9U_CDY384P=sSNP0ATYCb0nf1d=sbt5TjA@mail.gmail.com>
Subject: Re: PL/Java new build plugin
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000002353d905aa728baa"
Precedence: bulk

--0000000000002353d905aa728baa
Content-Type: text/plain; charset="UTF-8"

>
> Thanks! Looks like I have fixed that with a42c416. Turned out to be
> Windows line endings, and it means I gave you bad advice with regard to
> getPgConfigProperty [1] after all. Even though pg_config explicitly writes
> a single \n character on every platform, Windows (probably the C library
> really) still changes it to \r\n before it arrives on the pipe. So just
> removing one character won't always work. It has to be line.separator
> (that, or an explicit test for Windows). Sorry for leading you astray.
>
Thanks for informing this. I'll check the plugin with this fix to see if
this now works on Windows.

Now the only appveyor "errors" I'm seeing seem to be a result of appveyor
> thinking anything written to stderr is a problem. So running the installer
> jar to install the files produces a wall of red every time, because it
> prints the installed file names to stderr. And then on Java 9 there is
> still one JNI reference warning, but that's being treated as a failure.
>
> The first of those problems can surely be fixed with a 2>&1 on the
> command running the installer jar (or whatever the equivalent Windows
> syntax is for "merge your stderr into stdout").
>
> The second looks a little trickier, as you're probably checking for
> warning output from install_jar(...examples...), which really does
> indicate trouble, but the WARNING: JNI local refs: does not.

There is another error as well on PG 10
https://ci.appveyor.com/project/amCap1712/pljava/builds/34099990/job/bgpqdy5qjkik2ya9,
one of the tests fails. This has been the case since I first added this
configuration.

I don't understand what the PG=9 configuration even is. The PG version
> numbering change happened in 10, so "9" could mean any of seven different
> major versions, and I can't even see from the log which of those the
> run is trying to use. I think that could be the reason it's failing too,
> because it's trying to run "\Program Files\PostgreSQL\9\bin\pg_ctl" and
> there is no such thing with just "9" as the version.
>
I had suspected the same but didn't test it due to some reason I seem to
have forgotten but I will do that now.

--0000000000002353d905aa728baa
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">Thanks! Looks like I have fixed that with a42c416. Turne=
d out to be<br>
Windows line endings, and it means I gave you bad advice with regard to<br>
getPgConfigProperty [1] after all. Even though pg_config explicitly writes<=
br>
a single \n character on every platform, Windows (probably the C library<br=
>
really) still changes it to \r\n before it arrives on the pipe. So just<br>
removing one character won&#39;t always work. It has to be line.separator<b=
r>
(that, or an explicit test for Windows). Sorry for leading you astray.<br><=
/blockquote><div>Thanks for informing this. I&#39;ll check the plugin with =
this fix to see if this now works on Windows.</div><div><br></div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">
Now the only appveyor &quot;errors&quot; I&#39;m seeing seem to be a result=
 of appveyor<br>
thinking anything written to stderr is a problem. So running the installer<=
br>
jar to install the files produces a wall of red every time, because it<br>
prints the installed file names to stderr. And then on Java 9 there is<br>
still one JNI reference warning, but that&#39;s being treated as a failure.=
<br>
<br>
The first of those problems can surely be fixed with a 2&gt;&amp;1 on the<b=
r>
command running the installer jar (or whatever the equivalent Windows<br>
syntax is for &quot;merge your stderr into stdout&quot;).<br>
<br>
The second looks a little trickier, as you&#39;re probably checking for<br>
warning output from install_jar(...examples...), which really does<br>
indicate trouble, but the WARNING: JNI local refs: does not.</blockquote><d=
iv>There is another error as well on PG 10=C2=A0<a href=3D"https://ci.appve=
yor.com/project/amCap1712/pljava/builds/34099990/job/bgpqdy5qjkik2ya9">http=
s://ci.appveyor.com/project/amCap1712/pljava/builds/34099990/job/bgpqdy5qjk=
ik2ya9</a>, one of the tests fails. This has been the case since I first ad=
ded this configuration.</div><div><br></div><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">
I don&#39;t understand what the PG=3D9 configuration even is. The PG versio=
n<br>
numbering change happened in 10, so &quot;9&quot; could mean any of seven d=
ifferent<br>
major versions, and I can&#39;t even see from the log which of those the<br=
>
run is trying to use. I think that could be the reason it&#39;s failing too=
,<br>
because it&#39;s trying to run &quot;\Program Files\PostgreSQL\9\bin\pg_ctl=
&quot; and<br>
there is no such thing with just &quot;9&quot; as the version.<br></blockqu=
ote><div>I had suspected the same but didn&#39;t test it due to some reason=
 I seem to have forgotten but I will do that now.</div></div></div>

--0000000000002353d905aa728baa--