MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F2A29E4.2000803@anastigmatix.net>
 <CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com>
 <5F2EB313.8090706@anastigmatix.net>
 <CAASLQ4M0uvNj0EyMWWNsizT1KtnWx0WFbk89ud9EVHZbu12LMg@mail.gmail.com>
 <5F2EC4F4.3080608@anastigmatix.net>
 <CAASLQ4M3pR+ZL+uPvcQ-dAEL2KdH_PGe-_pBhsjvOgN5qvf+aA@mail.gmail.com>
 <5F31EFEC.1080609@anastigmatix.net>
 <CAASLQ4NU9v=nuLDG-LneC68LuqKRXchFckU7mCZT9YQDNKqwvg@mail.gmail.com>
 <5F368380.9070203@anastigmatix.net>
 <CAASLQ4NgH+tXbdUSA8xDh2ct3gAS3xa8V7=E0gcYd+d=m8kujw@mail.gmail.com>
 <5F368A99.6070709@anastigmatix.net> <5F36965C.60707@anastigmatix.net>
 <5F3A7DC6.8090905@anastigmatix.net>
 <CAASLQ4PEgo5Nj0EVsOfGoB96dQFXfFYxrrB0rS1wdad7x_E5fA@mail.gmail.com>
 <CAASLQ4OowXOmnbbbT0Wh1ZkB4h=6JQfC61ojmN07EYnO0QCcow@mail.gmail.com>
 <5F3D32E9.80504@anastigmatix.net> <5F3D36BE.70703@anastigmatix.net>
 <5F3D38F8.7050907@anastigmatix.net> <5F3D3A75.5010304@anastigmatix.net>
 <5F3D3D2E.4070109@anastigmatix.net>
In-Reply-To: <5F3D3D2E.4070109@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Thu, 20 Aug 2020 22:30:04 +0530
Message-ID: 
 <CAASLQ4P-VeZK46t=PvYw0F05AxqG5i80GTwg2LMhCnjC9WzoZA@mail.gmail.com>
Subject: ScriptingMojo Custom Packaging
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000f2315405ad520d12"
Precedence: bulk

--000000000000f2315405ad520d12
Content-Type: text/plain; charset="UTF-8"

>
> I think my inclination would be to supply such a file with the role-hint
> of 'pgxs', and mapping every phase to empty. Then what the plugin does will
> be completely determined by what script <execution>s you configure, and
> what phases you put them in.
>
> Then the packaging type of pljava-so could be pgxs, and you would simply
> specify the <phase> for each <execution> in the pom (as is already done
> for the set-properties execution). So, what the plugin does will be
> completely determined by what script <execution>s you configure, and
> what phases you put them in.
>
> I think I would also change ScriptingMojo to declare COMPILE as its
> default phase. The set-properties execution would still specify
> initialize as its phase, as it does now, but I think the usual
> behavior is if a phase isn't specified, it will be compile.
>

I have made these changes
https://github.com/amCap1712/pljava/commit/14045b10ca1428fc2914440a2220871ac7c9921b
but the build process fails with this error
https://gist.github.com/amCap1712/ad9fe94fd9fb6f4ff4f26913a464c226. I
checked the jar files manually to make sure the file is present in it. The
pgxs jar is also listed in the lists of url classpaths.

--000000000000f2315405ad520d12
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex">I think my inclination would be to supply such a file wi=
th the role-hint<br>
of &#39;pgxs&#39;, and mapping every phase to empty. Then what the plugin d=
oes will<br>
be completely determined by what script &lt;execution&gt;s you configure, a=
nd<br>
what phases you put them in.<br>
<br>
Then the packaging type of pljava-so could be pgxs, and you would simply<br=
>
specify the &lt;phase&gt; for each &lt;execution&gt; in the pom (as is alre=
ady done<br>
for the set-properties execution). So, what the plugin does will be<br>
completely determined by what script &lt;execution&gt;s you configure, and<=
br>
what phases you put them in.<br>
<br>
I think I would also change ScriptingMojo to declare COMPILE as its<br>
default phase. The set-properties execution would still specify<br>
initialize as its phase, as it does now, but I think the usual<br>
behavior is if a phase isn&#39;t specified, it will be compile.<br></blockq=
uote><div><br></div><div>I have made these changes=C2=A0<a href=3D"https://=
github.com/amCap1712/pljava/commit/14045b10ca1428fc2914440a2220871ac7c9921b=
">https://github.com/amCap1712/pljava/commit/14045b10ca1428fc2914440a222087=
1ac7c9921b</a></div><div>but the build process fails with this error=C2=A0<=
a href=3D"https://gist.github.com/amCap1712/ad9fe94fd9fb6f4ff4f26913a464c22=
6">https://gist.github.com/amCap1712/ad9fe94fd9fb6f4ff4f26913a464c226</a>. =
I checked the jar files manually to make sure the file is present in it. Th=
e pgxs jar is also listed in the lists of url classpaths.</div></div></div>

--000000000000f2315405ad520d12--