MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F22DF79.2090701@anastigmatix.net>
 <CAASLQ4POay=ZLsdOb02n6NqwTn7MGyyWQprcCEo2Wm6Y6rStEw@mail.gmail.com>
 <5F230337.3040406@anastigmatix.net>
 <CAASLQ4Ny+VWWH=_AR+=7gjXinUScybraOJxBUaG5AmLZmx+NPQ@mail.gmail.com>
 <5F232EBB.9030208@anastigmatix.net>
 <CAASLQ4OknEQTpSeoBfyAZR1na-EyL+AtN9t0fPGyv5DfWJOSWA@mail.gmail.com>
 <CAASLQ4NHROvOq-rUz6Jn0dUd7oAq3_P655WNeqKksNBqFtAGgw@mail.gmail.com>
 <CAASLQ4OCLUYXpkk0tTioz8=zc4UEbAm-Whgp_5K7uy-5hZdjKA@mail.gmail.com>
 <5F278CCE.1090006@anastigmatix.net>
 <CAASLQ4M8cN20L7cyVEgks9qdnfsXH4ci7iQbmyi4v_y0W85eLA@mail.gmail.com>
 <5F2897AF.9040909@anastigmatix.net>
 <CAASLQ4MLFnD3v_fqrUj+Bwc9MSBG-ATet3J7UXebzXHTH_si3A@mail.gmail.com>
 <5F2A29E4.2000803@anastigmatix.net>
 <CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com>
 <5F2EB313.8090706@anastigmatix.net>
 <CAASLQ4M0uvNj0EyMWWNsizT1KtnWx0WFbk89ud9EVHZbu12LMg@mail.gmail.com>
 <5F2EC4F4.3080608@anastigmatix.net>
In-Reply-To: <5F2EC4F4.3080608@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Sat, 8 Aug 2020 22:24:27 +0530
Message-ID: 
 <CAASLQ4P6wvh6pR4JCAGEJ5K4W+Y3q7z+p5xqd9QtLAiyREv2pQ@mail.gmail.com>
Subject: Re: the ReportScriptingMojo
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000029034105ac609428"
Precedence: bulk

--00000000000029034105ac609428
Content-Type: text/plain; charset="UTF-8"

On Sat, Aug 8, 2020 at 8:59 PM Chapman Flack <chap@anastigmatix.net> wrote:

> Hi Kartik,
>
> There are a couple more methods it might be useful for getScriptEngine
> to load into a script engine by default.
>
> If you look in the javadoc script for pljava-examples, there's a test
> for whether the saxon-examples profile is active.
>
> It's an easy test, but I can foresee it showing up in compiling scripts
> as well, so a simple boolean isProfileActive(String id) method is probably
> worth supplying.
>
> If supplying one from PGXSUtils, I would probably also have the method
> check that the argument profile name is even a known profile in the POM,
> and warn if it isn't. That would catch cases where somebody edits a POM
> and deletes a profile, not realizing a script was checking for it.
> I think all the known profiles are in project.getModel().getProfiles().
>
>
>
>
> You'll also see the -examples script generates the -classpath argument
> by stringing together project.compileClasspathElements. That works for
> -examples because the -examples code isn't modular.
>
> I did not change the scripts in pljava/ and pljava-api/ because those
> are modular code, and need to generate a --module-path instead. In
> general, Maven's compileClasspathElements might include both: elements
> that belong on the module path, elements that belong on the class path
> because they aren't modules.
>
> So that suggests a useful method like
>
> Map<String,String> buildPaths(List<String> elements)
>
> where you could pass it a list of elements (from compileClasspathElements
> or runtimeClasspathElements, etc.) and get back a map m such that
> m['classpath'] has all the elements that aren't modules, and
> m['modulepath'] has the elements that are (both with pathSeparator between
> elements).
>
> An element is a module if it is a directory and has a module-info.class,
> or it is a jar and either contains a module-info.class or has an
> Automatic-Module-Name entry in its manifest.
>
> Such a method would also be a good place for checking that no element
> contains pathSeparator as part of its name, as that would lead to a
> malformed path,
>
> Regards,
> -Chap
>

Yeah, it is a good idea to have these methods. I'll work on this soon.
Regards,
Kartik

--00000000000029034105ac609428
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Sat, Aug 8, 2020 at 8:59 PM Chapman Fl=
ack &lt;<a href=3D"mailto:chap@anastigmatix.net">chap@anastigmatix.net</a>&=
gt; wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_q=
uote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,2=
04);padding-left:1ex">Hi Kartik,<br>
<br>
There are a couple more methods it might be useful for getScriptEngine<br>
to load into a script engine by default.<br>
<br>
If you look in the javadoc script for pljava-examples, there&#39;s a test<b=
r>
for whether the saxon-examples profile is active.<br>
<br>
It&#39;s an easy test, but I can foresee it showing up in compiling scripts=
<br>
as well, so a simple boolean isProfileActive(String id) method is probably<=
br>
worth supplying.<br>
<br>
If supplying one from PGXSUtils, I would probably also have the method<br>
check that the argument profile name is even a known profile in the POM,<br=
>
and warn if it isn&#39;t. That would catch cases where somebody edits a POM=
<br>
and deletes a profile, not realizing a script was checking for it.<br>
I think all the known profiles are in project.getModel().getProfiles().<br>
<br>
<br>
<br>
<br>
You&#39;ll also see the -examples script generates the -classpath argument<=
br>
by stringing together project.compileClasspathElements. That works for<br>
-examples because the -examples code isn&#39;t modular.<br>
<br>
I did not change the scripts in pljava/ and pljava-api/ because those<br>
are modular code, and need to generate a --module-path instead. In<br>
general, Maven&#39;s compileClasspathElements might include both: elements<=
br>
that belong on the module path, elements that belong on the class path<br>
because they aren&#39;t modules.<br>
<br>
So that suggests a useful method like<br>
<br>
Map&lt;String,String&gt; buildPaths(List&lt;String&gt; elements)<br>
<br>
where you could pass it a list of elements (from compileClasspathElements<b=
r>
or runtimeClasspathElements, etc.) and get back a map m such that<br>
m[&#39;classpath&#39;] has all the elements that aren&#39;t modules, and<br=
>
m[&#39;modulepath&#39;] has the elements that are (both with pathSeparator =
between<br>
elements).<br>
<br>
An element is a module if it is a directory and has a module-info.class,<br=
>
or it is a jar and either contains a module-info.class or has an<br>
Automatic-Module-Name entry in its manifest.<br>
<br>
Such a method would also be a good place for checking that no element<br>
contains pathSeparator as part of its name, as that would lead to a<br>
malformed path,<br>
<br>
Regards,<br>
-Chap<br></blockquote><div><br></div><div>Yeah, it is a good idea to have t=
hese methods. I&#39;ll work on this soon.</div><div>Regards,</div><div>Kart=
ik</div></div></div>

--00000000000029034105ac609428--