Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jy4Ls-0006HU-GE for pljava-dev@arkaria.postgresql.org; Wed, 22 Jul 2020 02:19:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jy4Lq-0005DX-K9 for pljava-dev@arkaria.postgresql.org; Wed, 22 Jul 2020 02:19:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jy4Lq-0005DP-DN for pljava-dev@lists.postgresql.org; Wed, 22 Jul 2020 02:19:22 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jy4Ln-0002d9-SQ for pljava-dev@lists.postgresql.org; Wed, 22 Jul 2020 02:19:21 +0000 Received: by mail-ed1-x534.google.com with SMTP id d18so479473edv.6 for ; Tue, 21 Jul 2020 19:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lhGva3hdltrgxoP4B4AC00HSu4o3SM/5CMdN9zzylkQ=; b=S3mkJlGexcHGcUbg+bqZszZXP2s1agI9n94lROXdUXgkJoOSfs1d6f9odf9Q82yIKt sl+uf2sNohnS0kuO1gjlga5FSDmjvcgGaZJbQgzvAzwS/5ZhV5UL1J2YseZXR41T0B2V JzIaRrbqgW7t2cy8822d59gNkci1rl2IHeykT/B6VGdPeaD4ncJYZeZw/YmdTG3WCev2 zv6vp3Uuvmbu3zdL2qUn1jweWoHOFreLiK1rmdWjrf8nsksdyIwwuM6/UluuLjadR7u9 3Bj/tz5ead+cXMT7yM4d5QT8xs0zKZFLuCwKsdE40+WL37QKO7kc/ExoY3GP1VeWC8Qp 05Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lhGva3hdltrgxoP4B4AC00HSu4o3SM/5CMdN9zzylkQ=; b=X+iKVqy/SCvimLjiJPK911NllBMG2UCryEi+iqF5y2nmOX5PieGAC7ffYSiR+FONIj /qa6ZkSn2WBgQ+zEM7cymP6ALrFg25WLd4jtZFsbPLhl4Y07kKrbzgTNgnxVKOLYTc9n O8sXwZnhmZCVNzBllGp46f4/6NPQyEY3gls7SHKJc/uT6sD5P/uZFo4Um+Dr7uFcm+qB T0mX3jihMof8orTPNR7iz21HK9lScqnVRFMNc7n7ZgYgXp7SjqwBFnLtVCY9+j/JMQWt O4nrQz0QV/bNqVD1Gmg8iMHrwHMK+jGhDnCjISwEgdiPUNV6lK/0haWlBDtgSCg2QaGf Tnzw== X-Gm-Message-State: AOAM531SSPSEuHCLnuqU3hj7ZzxqLl1KEEc8akdPrE2+g1KkYz3bh2yT CiIVePgYOcxTUSMkcYE7QZBw0Dcwp5Khod8ECSqONUnNMEs= X-Google-Smtp-Source: ABdhPJxU9y7oSzWTLqilRGtHOQ607q293GFOmsCWim2smK1/FXkCxGk4RSP48flKyioJFTJcuBlvZ/v8KXblWi72/jU= X-Received: by 2002:aa7:c4d8:: with SMTP id p24mr27830303edr.323.1595384357103; Tue, 21 Jul 2020 19:19:17 -0700 (PDT) MIME-Version: 1.0 References: <5F12FF49.6090906@anastigmatix.net> <5F12FF80.5020208@anastigmatix.net> <5F1338F8.6030506@anastigmatix.net> <5F135B84.8070302@anastigmatix.net> <5F14C34E.4020704@anastigmatix.net> <5F14E15A.4040202@anastigmatix.net> <5F1664C5.2070700@anastigmatix.net> <5F1735ED.6020707@anastigmatix.net> <5F176C77.4040601@anastigmatix.net> In-Reply-To: <5F176C77.4040601@anastigmatix.net> From: Kartik Ohri Date: Wed, 22 Jul 2020 07:49:05 +0530 Message-ID: Subject: Re: PL/Java new build plugin To: Chapman Flack Cc: pljava-dev@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000e2abca05aafe5df7" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e2abca05aafe5df7 Content-Type: text/plain; charset="UTF-8" On Wed, Jul 22, 2020 at 4:00 AM Chapman Flack wrote: > On 07/21/20 14:55, Kartik Ohri wrote: > > I had already come across your answer in my search and figured that you > > might have forgotten about it :). I have seen antrun's source. I > initially > > wanted to have something like it but was unable to figure out how > > antrun does that. > > That made me curious, so I took your plugin branch and just gave the > 'script' parameter the type PlexusConfiguration, and it did pretty much > what I thought antrun was doing. Nothing up my sleeve. :) > https://github.com/jcflack/pljava/commits/PlexusConfig > > One less dark magical secret. So, this means that Maven looks for @Parameter annotated variables and matches them to xml dom elements. And the supertype for maven plugin parameter type matching is PlexusConfiguration (or something it inherits). Is it possible that the test condition for "your engine doesn't support > your mimetype" could be backwards? To be sure, you mean the mimetype should be preferred over engine ? Regards, Kartik. --000000000000e2abca05aafe5df7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jul 22, 2020 at 4:00 AM Chapman F= lack <chap@an= astigmatix.net> wrote:
On 07/21/20 14:55, Kartik Ohri wro= te:
> I had already come across your answer in my search and figured that yo= u
> might have forgotten about it :). I have seen antrun's source. I i= nitially
> wanted=C2=A0 to have something like it but was unable to figure out ho= w
> antrun does that.

That made me curious, so I took your plugin branch and just gave the
'script' parameter the type PlexusConfiguration, and it did pretty = much
what I thought antrun was doing. Nothing up my sleeve. :)=C2=A0
=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex"> https://github.com/jcflack/pljava/commits/Plex= usConfig

One less dark magical secret. So, this means that Mav= en looks for=C2=A0@Parameter annotated variables and matches them to xml do= m elements. And the supertype for maven plugin parameter type matching is P= lexusConfiguration (or something it inherits).

Is it possible that the test cond= ition for "your engine doesn't support
your mimetype" could be backwards?
To be sure, you me= an the mimetype should be preferred over engine ?=C2=A0=C2=A0
Regards,
Kartik.
--000000000000e2abca05aafe5df7--