MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5F368380.9070203@anastigmatix.net>
 <CAASLQ4NgH+tXbdUSA8xDh2ct3gAS3xa8V7=E0gcYd+d=m8kujw@mail.gmail.com>
 <5F368A99.6070709@anastigmatix.net> <5F36965C.60707@anastigmatix.net>
 <5F3A7DC6.8090905@anastigmatix.net>
 <CAASLQ4PEgo5Nj0EVsOfGoB96dQFXfFYxrrB0rS1wdad7x_E5fA@mail.gmail.com>
 <CAASLQ4OowXOmnbbbT0Wh1ZkB4h=6JQfC61ojmN07EYnO0QCcow@mail.gmail.com>
 <5F3D32E9.80504@anastigmatix.net> <5F3D36BE.70703@anastigmatix.net>
 <5F3D38F8.7050907@anastigmatix.net> <5F3D3A75.5010304@anastigmatix.net>
 <5F3D3D2E.4070109@anastigmatix.net> <5F3D43BD.4020900@anastigmatix.net>
 <5F3DA48D.7090408@anastigmatix.net>
 <CAASLQ4MBWQeFLdAPNcsgcpLyekU5X=ExQUuGgE49AUFdEYJr8g@mail.gmail.com>
 <5F41943D.9080707@anastigmatix.net>
 <CAASLQ4P5oEx0DLoDLEOAkZSwffU2eS2+NKbevgYqpknHGucaTw@mail.gmail.com>
 <5F427604.5010103@anastigmatix.net>
 <CAASLQ4Nr3MPQuZziVU+89ULZ=BgQjaPPnCLsyPR3mhW-eWoOBw@mail.gmail.com>
 <5F42A71F.8000002@anastigmatix.net>
In-Reply-To: <5F42A71F.8000002@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Wed, 26 Aug 2020 02:36:33 +0530
Message-ID: 
 <CAASLQ4PkP017rtyUswKO_TCiNmnica-nrQHBgggFw-U_9MstUg@mail.gmail.com>
Subject: Re: the ScriptingMojo
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000a1248205adba1475"
Precedence: bulk

--000000000000a1248205adba1475
Content-Type: text/plain; charset="UTF-8"

Hi!


> - I don't think formatDefines and formatIncludes make good PGXSUtils
>   methods. The syntax could vary across compilers (might it use /D or /I
>   on a Windows compiler, for example?). So I think they make better
>   AbstractPGXS methods that can be overridden in the configuration.
>   There could be a built-in implementation in AbstractPGXS using -D and -I.
>   Defines should be provided as a map (key to value) and the option string
>   with = sign should be produced by formatting.
>
> Regarding this, it seems that it is not possible to invoke a method whose
implementation
is provided in the Java class before an object is created. (Same for
default methods in an
interface) So, compile itself cannot call a formatDefines if a default
implementation is given using
AbstractPGXS. However, formatDefines can be called separately and the value
be passed to compile.
So, it would need creating a define method which also decides the defines
for the interface and
formats them. Another way is to pass the formatDefines function as a
parameter to compile. But
this only works for Graal and not nashorn. I am not sure whether nashorn
doesn't support it or there is
some way to do it I do not know of.

Thanks.
Regards,
Kartik

--000000000000a1248205adba1475
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><div>Hi!</div><div>=C2=A0</div>=
<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-=
left:1px solid rgb(204,204,204);padding-left:1ex">- I don&#39;t think forma=
tDefines and formatIncludes make good PGXSUtils<br>
=C2=A0 methods. The syntax could vary across compilers (might it use /D or =
/I<br>
=C2=A0 on a Windows compiler, for example?). So I think they make better<br=
>
=C2=A0 AbstractPGXS methods that can be overridden in the configuration.<br=
>
=C2=A0 There could be a built-in implementation in AbstractPGXS using -D an=
d -I.<br>
=C2=A0 Defines should be provided as a map (key to value) and the option st=
ring<br>
=C2=A0 with =3D sign should be produced by formatting.<br>
<br></blockquote><div>Regarding this, it seems that it is not possible to i=
nvoke a method whose implementation</div><div>is provided in the Java class=
 before an object is created. (Same for default methods in an</div><div>int=
erface) So, compile itself cannot call a formatDefines if a default impleme=
ntation=C2=A0is given using</div><div>AbstractPGXS. However, formatDefines =
can be called separately and the value be passed to compile.</div><div>So, =
it would need creating a define method which also decides the defines for t=
he interface and</div><div>formats them. Another=C2=A0way is to pass the fo=
rmatDefines function as a parameter to compile. But=C2=A0</div><div>this on=
ly works for Graal and not nashorn. I am not sure whether nashorn doesn&#39=
;t support it or there is</div><div>some way to do it I do not know of.</di=
v><div><br></div><div>Thanks.</div><div>Regards,</div><div>Kartik</div></di=
v></div>

--000000000000a1248205adba1475--