public inbox for [email protected]  
help / color / mirror / Atom feed
From: Kartik Ohri <[email protected]>
To: Chapman Flack <[email protected]>
Cc: [email protected]
Subject: Re: PL/Java new build plugin
Date: Tue, 21 Jul 2020 08:29:13 +0530
Message-ID: <CAASLQ4PnDvNwJqMXALCbfAasFAXA6U_Yhf_uM6xAhx0XgyybpA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
	<[email protected]>
	<CAASLQ4NmornyOW8n-qyneLpDVPgV0Js=+=Eys6bw3Y-ZiVbVjA@mail.gmail.com>
	<CAASLQ4OYvTQL7ssG4=QyEqhaB71=AM-svBUYj3uRdWXWoQgBPw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAASLQ4N40xn-0S4Nsy0Ld75=Ny719MPUE7_aRP_5nAcAqkAqoQ@mail.gmail.com>
	<CAASLQ4OiWCQQwYFnxAQBe2dC6Ms803RjCMX-9AC2=1m0ZzeDhA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAASLQ4MqSVnhK_GMgq03HcmOKk7a-v7b4L0yfPbtRO=mpqoQtA@mail.gmail.com>
	<[email protected]>
	<CAASLQ4OR8ZD4GRNHVGuTzJp_UP-PAcADxcz=uymiSFPpg8EEHQ@mail.gmail.com>
	<[email protected]>
	<CAASLQ4O=tYGASWB6F+PTiB2L3RbmHcVX8XAbKHyhwBDOodH1zg@mail.gmail.com>
	<CAASLQ4P=c42e342-1YTTCBxA=CKBH2m=DLJN+ZQb5EJW6MyofQ@mail.gmail.com>
	<CAASLQ4NU3BgfCnVxvAbu9vK9+gtPT87xX1uBj57b0y2J6nxi+Q@mail.gmail.com>
	<[email protected]>

>
> Something isn't quite right about the handling of -Dpljava.libjvmdefault;
> the C compiler gives syntax errors if I use it (the build succeeds if
> I don't). Running with -X shows this being passed to the compiler:
>
> -DPLJAVA_LIBJVMDEFAULT=${pljava.qlibjvmdefault}
>
It is because the plugin is no longer detecting PLJAVA_LIBJVMDEFAULT. I did
not retain the method to automatically detect the variable and use it and
set its value. Should we keep it in the configuration block in pom.xml
since we have exposed the C quoting as well to the script engine or make an
exception for this to be specified via command line ?


view thread (132+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: PL/Java new build plugin
  In-Reply-To: <CAASLQ4PnDvNwJqMXALCbfAasFAXA6U_Yhf_uM6xAhx0XgyybpA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox