MIME-Version: 1.0
References: 
 <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
 <5EF7B265.3060907@anastigmatix.net>
 <CAASLQ4P6vTfRNVnreNp7Su8VmyhA+wKOYDY8iUfa7eSoogFkXA@mail.gmail.com>
 <5EFA6C22.8060006@anastigmatix.net> <5EFC18D9.3090108@anastigmatix.net>
 <CAASLQ4N0KeUx8PaJMKbHWiVtLvBo3QNACdHgOyk72q30976d+g@mail.gmail.com>
 <5EFD41B1.30009@anastigmatix.net>
 <CAASLQ4NvfJz8VQQFU8mKkY4RabiVQesxdbkudk5Cf24Tm9BixQ@mail.gmail.com>
 <5EFE0A4D.8060402@anastigmatix.net>
 <CAASLQ4M3+XNBYiHMg32X6poY25eMbvMC5MHbA48pt30QK8nAww@mail.gmail.com>
 <5F0125BC.5000609@anastigmatix.net>
In-Reply-To: <5F0125BC.5000609@anastigmatix.net>
From: Kartik Ohri <kartikohri13@gmail.com>
Date: Sun, 5 Jul 2020 10:05:46 +0530
Message-ID: 
 <CAASLQ4PtGSS-OP9k_740EBdyT1bVmDi1PUndn1ZNWzyJDRQkMA@mail.gmail.com>
Subject: Re: PL/Java new build plugin
To: Chapman Flack <chap@anastigmatix.net>
Cc: pljava-dev@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000006451d005a9aa4be3"
Precedence: bulk

--0000000000006451d005a9aa4be3
Content-Type: text/plain; charset="UTF-8"

>
> The commit where I tweaked for the custom suffixes was bf59577, and
> the one for the PG10 numbering change was c434748. The commit comments
> and diffs give some insight into what was changed and why. (Have you
> played with 'blame' in git before?)
>
No, I do not know about git blame but I will take a look and learn about
that.

It looks as if you copied the expressions faithfully, except perhaps
> for the flags that are set for the first one. That probably doesn't
> explain any problem you're having (though it should be fixed anyway),
> as that first pattern isn't even in play unless you are building against
> a devel, alpha, beta, or rc version of PostgreSQL.
>
I had checked about the si flag and think it is probably the same function
as the DOTALL flag I set for that pattern.

Can you supply an example of what is going wrong?
>
After the replacement, the string when written to file displays some empty
boxes instead of the correct version. I'll share an example soon.

One last thing, not regex related:
>
> You can see the original build.xml code invokes pg_config multiple
> times, reading one configuration value each time, and the same is
> done by PGXS in Makefile.global [1].
>
> It does seem more efficient to invoke pg_config only once and parse
> its output for the various values, as you are doing here.
>
> What could be the reason existing code avoided doing that?
>
I saw this as well and though that the plugin in POM executed multiple
times with the specific argument to assign the entire output as the
property. I did  not go with that approach because I thought it was simply
not possible for that plugin to read the output and process it to store
different parts in multiple properties. I believe it to be the case with
PGXS as well since both of them are generic and need to cater various use
cases.

--0000000000006451d005a9aa4be3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div class=3D"gmail_quote" dir=3D"auto"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">The commit where I tweaked for the custom suffixes was bf5957=
7, and<br>
the one for the PG10 numbering change was c434748. The commit comments<br>
and diffs give some insight into what was changed and why. (Have you<br>
played with &#39;blame&#39; in git before?)<br></blockquote></div><div dir=
=3D"auto">No, I do not know about git blame but I will take a look and lear=
n about that.</div><div dir=3D"auto"><br></div><div class=3D"gmail_quote" d=
ir=3D"auto"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bo=
rder-left:1px #ccc solid;padding-left:1ex">It looks as if you copied the ex=
pressions faithfully, except perhaps<br>
for the flags that are set for the first one. That probably doesn&#39;t<br>
explain any problem you&#39;re having (though it should be fixed anyway),<b=
r>
as that first pattern isn&#39;t even in play unless you are building agains=
t<br>
a devel, alpha, beta, or rc version of PostgreSQL.<br></blockquote></div><d=
iv dir=3D"auto">I had checked about the si flag and think it is probably th=
e same function as the DOTALL flag I set for that pattern.</div><div dir=3D=
"auto"><br></div><div class=3D"gmail_quote" dir=3D"auto"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">
Can you supply an example of what is going wrong?<br></blockquote></div><di=
v dir=3D"auto">After the replacement, the string when written to file displ=
ays some empty boxes instead of the correct version. I&#39;ll share an exam=
ple soon.</div><div dir=3D"auto"><br></div><div class=3D"gmail_quote" dir=
=3D"auto"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bord=
er-left:1px #ccc solid;padding-left:1ex">
One last thing, not regex related:<br>
<br>
You can see the original build.xml code invokes pg_config multiple<br>
times, reading one configuration value each time, and the same is<br>
done by PGXS in Makefile.global [1].<br>
<br>
It does seem more efficient to invoke pg_config only once and parse<br>
its output for the various values, as you are doing here.<br>
<br>
What could be the reason existing code avoided doing that?<br></blockquote>=
</div><div dir=3D"auto">I saw this as well and though that the plugin in PO=
M executed multiple times with the specific argument to assign the entire o=
utput as the property. I did=C2=A0 not go with that approach because I thou=
ght it was simply not possible for that plugin to read the output and proce=
ss it to store different parts in multiple properties. I believe it to be t=
he case with PGXS as well since both of them are generic and need to cater =
various use cases.</div></div>

--0000000000006451d005a9aa4be3--