MIME-Version: 1.0
In-Reply-To: <56759A57.9060106@anastigmatix.net>
References: <56759A57.9060106@anastigmatix.net>
Date: Mon, 21 Dec 2015 01:11:31 +0000
Message-ID: 
 <CAKJ3sLy04vuLwnDNBrMnGAp=npj4R9x2cG10=Jc_6sLfBDFBnQ@mail.gmail.com>
Subject: Re: [Pljava-dev] annotation keyword changes before 1.5.0 (?)
From: Peter Henderson <peter.henderson@starjar.com>
Content-Type: multipart/alternative; boundary=001a113e51545c80f105275e2be2

--001a113e51545c80f105275e2be2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Just my =C2=A30.0002 worth

On Sat, Dec 19, 2015 at 5:56 PM, Chapman Flack <chap@anastigmatix.net>
wrote:

> There has been some code in the tree for Java annotation support
> ever since January 2005, but I'm not sure how usable or used it
> was before March 2013. That was after the most recent numbered
> release, so I think 1.5.0 will be the first numbered release
> featuring annotation support in a significant way. So, there will
> probably never be a better time to change any of the annotation
> keywords, if they are worth changing. No one who has been using
> prebuilt distributions from pgFoundry will have used them yet.
>
> - In a @Function annotation, the keyword 'type' is used to specify
>   the volatility category (volatile, stable, immutable). That dates
>   all the way back to 2005, but I'd rather have 'type' mean
>   the SQL type of the function return (right now, you have to say
>   'complexType' for that, which isn't intuitive). I was stuck for a
>   a while on a good, short, alternative keyword. I'm not thrilled
>   with 'volatility' because it's both long and semi-redundant
>   (volatility=3Dvolatile makes you snicker, volatility=3Dimmutable
>   makes you wince). I think my current favorite idea is 'effects'.
>   I think all of (effects=3Dvolatile, effects=3Dstable, effects=3Dimmutab=
le)
>   will be clear at sight when you know the PostgreSQL concepts.
>

Personally I'd prefer names similar to those used in the main documentation
http://www.postgresql.org/docs/9.4/static/xfunc-volatility.html

volatility=3DVolatile
volatility=3DStable
volatility=3DImmutable

Make sense to me. Plus relate to the same terms used by a PL/pgSQL function=
.




> Any reactions or suggestions to the above (including "wait! stop! nooo,
> don't change any keywords!") welcome.
>
> -Chap
> _______________________________________________
> Pljava-dev mailing list
> Pljava-dev@lists.pgfoundry.org
> http://lists.pgfoundry.org/mailman/listinfo/pljava-dev
>



--=20
Peter Henderson

Director
Starjar Ltd.
www.starjar.com
0330 088 1662

--001a113e51545c80f105275e2be2
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Just my =C2=A30.0002 worth<br><div><div class=3D"gmail_ext=
ra"><br><div class=3D"gmail_quote">On Sat, Dec 19, 2015 at 5:56 PM, Chapman=
 Flack <span dir=3D"ltr">&lt;<a href=3D"mailto:chap@anastigmatix.net" targe=
t=3D"_blank">chap@anastigmatix.net</a>&gt;</span> wrote:<br><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">There has been some code in the tree for=
 Java annotation support<br>
ever since January 2005, but I&#39;m not sure how usable or used it<br>
was before March 2013. That was after the most recent numbered<br>
release, so I think 1.5.0 will be the first numbered release<br>
featuring annotation support in a significant way. So, there will<br>
probably never be a better time to change any of the annotation<br>
keywords, if they are worth changing. No one who has been using<br>
prebuilt distributions from pgFoundry will have used them yet.<br>
<br>
- In a @Function annotation, the keyword &#39;type&#39; is used to specify<=
br>
=C2=A0 the volatility category (volatile, stable, immutable). That dates<br=
>
=C2=A0 all the way back to 2005, but I&#39;d rather have &#39;type&#39; mea=
n<br>
=C2=A0 the SQL type of the function return (right now, you have to say<br>
=C2=A0 &#39;complexType&#39; for that, which isn&#39;t intuitive). I was st=
uck for a<br>
=C2=A0 a while on a good, short, alternative keyword. I&#39;m not thrilled<=
br>
=C2=A0 with &#39;volatility&#39; because it&#39;s both long and semi-redund=
ant<br>
=C2=A0 (volatility=3Dvolatile makes you snicker, volatility=3Dimmutable<br>
=C2=A0 makes you wince). I think my current favorite idea is &#39;effects&#=
39;.<br>
=C2=A0 I think all of (effects=3Dvolatile, effects=3Dstable, effects=3Dimmu=
table)<br>
=C2=A0 will be clear at sight when you know the PostgreSQL concepts.<br></b=
lockquote><div><br></div><div>Personally I&#39;d prefer names similar to th=
ose used in the main documentation<br><a href=3D"http://www.postgresql.org/=
docs/9.4/static/xfunc-volatility.html">http://www.postgresql.org/docs/9.4/s=
tatic/xfunc-volatility.html</a><br><br></div><div><div>volatility=3DVolatil=
e<br></div>volatility=3DStable<br></div>volatility=3DImmutable<br><div><br>=
</div><div>Make sense to me. Plus relate to the same terms used by a PL/pgS=
QL function.<br></div><div><br><br>=C2=A0<br></div><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex">Any reactions or suggestions to the above (includ=
ing &quot;wait! stop! nooo,<br>
don&#39;t change any keywords!&quot;) welcome.<br>
<br>
-Chap<br>
_______________________________________________<br>
Pljava-dev mailing list<br>
<a href=3D"mailto:Pljava-dev@lists.pgfoundry.org">Pljava-dev@lists.pgfoundr=
y.org</a><br>
<a href=3D"http://lists.pgfoundry.org/mailman/listinfo/pljava-dev" rel=3D"n=
oreferrer" target=3D"_blank">http://lists.pgfoundry.org/mailman/listinfo/pl=
java-dev</a><br>
</blockquote></div><br><br clear=3D"all"><br>-- <br><div class=3D"gmail_sig=
nature"><div dir=3D"ltr"><div><div dir=3D"ltr"><span>Peter Henderson<br><br=
>
Director<br>
Starjar Ltd.<br>
<a href=3D"http://www.starjar.com" target=3D"_blank">www.starjar.com</a><br=
>0330 088 1662<br></span></div></div></div></div>
</div></div></div>

--001a113e51545c80f105275e2be2--