Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCFzJ-0007wf-6d for pljava-dev@arkaria.postgresql.org; Sun, 30 Aug 2020 05:34:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kCFzF-0007GM-RV for pljava-dev@arkaria.postgresql.org; Sun, 30 Aug 2020 05:34:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCFzF-0007FN-LB for pljava-dev@lists.postgresql.org; Sun, 30 Aug 2020 05:34:41 +0000 Received: from mail-lf1-f65.google.com ([209.85.167.65]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kCFzC-0008LD-I9 for pljava-dev@lists.postgresql.org; Sun, 30 Aug 2020 05:34:41 +0000 Received: by mail-lf1-f65.google.com with SMTP id k10so1778445lfm.5 for ; Sat, 29 Aug 2020 22:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=02Bd+c0+PRu0WXn9t0eXF8SfcO/ucWIIWjyy4T8Wb1g=; b=Ef9QD/SQAsodRudr78H3h3jxqoaydRof2j3x/4VZuJ/WpzpHMRlHAPpRPUvuA6Ixau yC3SbeikUXsPBN1hCck1c2E9Uu3/6kqWYDQ8ADjePzit3lPtC7/W9qM720aFKjJmuqBR ss8kq9kcH+WVVZ9ETnVvB1hJgRNf/kCLmlbQREQD63JlRJBZ4zTZbn5EgD6mb0oLL+xJ f6Uhw1UHIg/OjlywqAcw+5kYTYph185UkXmvKFpV6vJTKDk6QuQjueYPDXpEqY0TYoWZ YJyL6qGp4/Winwu2bj0bdSCzdVMaC17Om87V41irc6Exy2WlTJIAn+i/vwTLm1YA19pP zZRQ== X-Gm-Message-State: AOAM530gqTj++nloI85niKAGscu/rx0tESsVXtyIJgWiskM7Na+Zr4hl 7sp6MA64LDJ2mkT9TuIkkDXeF3oR/iZlYnqo4hg= X-Google-Smtp-Source: ABdhPJwzZBJjaQw/3l9W+iYClW/3bujNaxIwbGHEOLpHwZ7TC1yxn6LW+rhdAQLNDsMas7yb74FBgqixdbhp5tjA99o= X-Received: by 2002:ac2:4d0f:: with SMTP id r15mr2896789lfi.114.1598765677411; Sat, 29 Aug 2020 22:34:37 -0700 (PDT) MIME-Version: 1.0 References: <5EC17E17.7070002@anastigmatix.net> <5ED7E74B.9020800@anastigmatix.net> <5EDA576E.2000204@anastigmatix.net> <5EDBA5D9.8090506@anastigmatix.net> <5EE7AE8C.2040201@anastigmatix.net> <5EEA6F85.9040009@anastigmatix.net> <5F063C86.3070301@anastigmatix.net> <5F47EB62.2060306@anastigmatix.net> <5F4816A0.8020208@anastigmatix.net> <5F4A53C3.1040102@anastigmatix.net> <5F4A9ED8.9090907@anastigmatix.net> In-Reply-To: <5F4A9ED8.9090907@anastigmatix.net> Reply-To: thomas@tada.se From: Thomas Hallgren Date: Sun, 30 Aug 2020 07:34:26 +0200 Message-ID: Subject: Re: Travis and AppVeyor continuous integration [Re: feature/master/ci] To: Chapman Flack Cc: Kartik Ohri , pljava-dev@lists.postgresql.org Content-Type: multipart/alternative; boundary="00000000000048035005ae11a479" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000048035005ae11a479 Content-Type: text/plain; charset="UTF-8" I had no idea Travis-CI could be installed as an app with access to selected repositories. Thanks for pointing that out. As that addresses my concerns, it's now installed for the tada organization and has access to the pljava repo. Regards, Thomas On Sat, 29 Aug 2020 at 20:30, Chapman Flack wrote: > On 08/29/20 09:10, Chapman Flack wrote: > > Thomas, if their current permission requests, when configured as a > > GitHub App, are as Kartik describes, and can be limited to the PL/Java > > repo only, would that answer your concerns (even if not perfectly, > > perhaps acceptably)? > > > > It seems to me also that such concerns can have a "duration" dimension: > > if even their more limited, app-based, permissions are not entirely > > satisfactory, perhaps they would be tolerable for a limited period > > (a calendar quarter, perhaps) to immediately reap the benefits of > > Kartik's work while affording time to explore migrating the scripts > > to Github Actions without a rush? > > > Not having heard back from Thomas yet, I propose the following: > > I will merge PR #289. This will bring the current, working Travis and > AppVeyor configurations into the git history. No CI will happen, of course, > before the corresponding apps are set up. > > If Thomas is immovably opposed to setting up the apps, even with their > more limited permissions, for one repository only, perhaps for a limited > period, then the working Travis and AppVeyor configurations will be in > the history anyway, and can serve as starting points for GitHub Actions > workflows to be developed as time permits. > > In any case, Kartik, once I have merged #289, you will be able to rebase > feature/master/pgxs over master as feature/master/pgxs-2 and make a new > pull request to supersede #291. > > This should happen after the problem you just noticed in > getPgConfigPropertyAsList has been fixed (and a unit test added to > keep it fixed), and after adding -Dpljava.libjvmdefault on the mvn > build commands and removing pljava.libjvm_location from the jshell > test scripts, to confirm that the value gets correctly compiled in. > (The tests, of course, will not run in the main repo. but will still > run in yours.) > > Regards, > -Chap > --00000000000048035005ae11a479 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I had no idea Travis-CI could be installed as an app with access= to selected repositories. Thanks for pointing that out. As that addresses = my concerns, it's now installed for the tada organization and has acces= s to the pljava repo.

Regards,
Thomas


On Sat, 29 Aug 2020 at 2= 0:30, Chapman Flack <chap@anast= igmatix.net> wrote:
On 08/29/20 09:10, Chapman Flack wrote:
> Thomas, if their current permission requests, when configured as a
> GitHub App, are as Kartik describes, and can be limited to the PL/Java=
> repo only, would that answer your concerns (even if not perfectly,
> perhaps acceptably)?
>
> It seems to me also that such concerns can have a "duration"= dimension:
> if even their more limited, app-based, permissions are not entirely > satisfactory, perhaps they would be tolerable for a limited period
> (a calendar quarter, perhaps) to immediately reap the benefits of
> Kartik's work while affording time to explore migrating the script= s
> to Github Actions without a rush?


Not having heard back from Thomas yet, I propose the following:

I will merge PR #289. This will bring the current, working Travis and
AppVeyor configurations into the git history. No CI will happen, of course,=
before the corresponding apps are set up.

If Thomas is immovably opposed to setting up the apps, even with their
more limited permissions, for one repository only, perhaps for a limited period, then the working Travis and AppVeyor configurations will be in
the history anyway, and can serve as starting points for GitHub Actions
workflows to be developed as time permits.

In any case, Kartik, once I have merged #289, you will be able to rebase feature/master/pgxs over master as feature/master/pgxs-2 and make a new
pull request to supersede #291.

This should happen after the problem you just noticed in
getPgConfigPropertyAsList has been fixed (and a unit test added to
keep it fixed), and after adding -Dpljava.libjvmdefault on the mvn
build commands and removing pljava.libjvm_location from the jshell
test scripts, to confirm that the value gets correctly compiled in.
(The tests, of course, will not run in the main repo. but will still
run in yours.)

Regards,
-Chap
--00000000000048035005ae11a479--