MIME-Version: 1.0
References: <5F0D3FCB.6040604@anastigmatix.net>
In-Reply-To: <5F0D3FCB.6040604@anastigmatix.net>
Reply-To: thomas@tada.se
From: Thomas Hallgren <thomas@tada.se>
Date: Tue, 14 Jul 2020 07:35:14 +0200
Message-ID: 
 <CAO5TtCuMJ+w_VAW+DV0CxTN1fOstvSU_zMVm58i_TtycwKQ7uQ@mail.gmail.com>
Subject: Re: I propose to commit a .editorconfig file for PL/Java
To: Chapman Flack <chap@anastigmatix.net>
Cc: "pljava-dev@lists.postgresql.org" <pljava-dev@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000009b3d0705aa602c17"
Precedence: bulk

--0000000000009b3d0705aa602c17
Content-Type: text/plain; charset="UTF-8"

I think this sounds like a very good idea.

Best,
Thomas

On Tue, 14 Jul 2020 at 07:17, Chapman Flack <chap@anastigmatix.net> wrote:

> Peter Eisentraut added a .editorconfig in the root of PostgreSQL's
> source repository, just last December. [1]
>
> While it can simplify the process for new contributors getting the
> right editor settings for the project's formatting conventions, one
> immediate benefit should be that GitHub will display our sources
> with the intended indentation on the web.
>
> I propose to start with the same rules as in the file he committed, but
> without the exception for sgml and xml. (We don't have any sgml files,
> and the xml files we have are indented the same as other types.)
>
> Regards,
> -Chap
>
>
> [1]
>
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=ecb09cd;hp=2032645
>
>
>

--0000000000009b3d0705aa602c17
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-size:large;colo=
r:#000000">I think this sounds like a very good idea.</div><div class=3D"gm=
ail_default" style=3D"font-size:large;color:#000000"><br></div><div class=
=3D"gmail_default" style=3D"font-size:large;color:#000000">Best,</div><div =
class=3D"gmail_default" style=3D"font-size:large;color:#000000">Thomas</div=
></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr"=
>On Tue, 14 Jul 2020 at 07:17, Chapman Flack &lt;<a href=3D"mailto:chap@ana=
stigmatix.net">chap@anastigmatix.net</a>&gt; wrote:<br></div><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid=
 rgb(204,204,204);padding-left:1ex">Peter Eisentraut added a .editorconfig =
in the root of PostgreSQL&#39;s<br>
source repository, just last December. [1]<br>
<br>
While it can simplify the process for new contributors getting the<br>
right editor settings for the project&#39;s formatting conventions, one<br>
immediate benefit should be that GitHub will display our sources<br>
with the intended indentation on the web.<br>
<br>
I propose to start with the same rules as in the file he committed, but<br>
without the exception for sgml and xml. (We don&#39;t have any sgml files,<=
br>
and the xml files we have are indented the same as other types.)<br>
<br>
Regards,<br>
-Chap<br>
<br>
<br>
[1]<br>
<a href=3D"https://git.postgresql.org/gitweb/?p=3Dpostgresql.git;a=3Dcommit=
diff;h=3Decb09cd;hp=3D2032645" rel=3D"noreferrer" target=3D"_blank">https:/=
/git.postgresql.org/gitweb/?p=3Dpostgresql.git;a=3Dcommitdiff;h=3Decb09cd;h=
p=3D2032645</a><br>
<br>
<br>
</blockquote></div>

--0000000000009b3d0705aa602c17--