Message-ID: <gh-postgresql-interfaces-psqlodbc-1-rc1427431482@github.com>
From: "apgrucza (@apgrucza)" <noreply+apgrucza@github.com>
To: "postgresql-interfaces/psqlodbc" <noreply+postgresql-interfaces-psqlodbc@github.com>
Date: Fri, 15 Dec 2023 00:26:28 +0000
Subject: Re: [postgresql-interfaces/psqlodbc] PR #1: fix: if the connection is broken when calling SQLFreeHandle, the client can't be notified
In-Reply-To: <gh-postgresql-interfaces-psqlodbc-1@github.com>
References: <gh-postgresql-interfaces-psqlodbc-1@github.com>
List-Id: <gh-postgresql-interfaces-psqlodbc.github.com>
X-GitHub-Author-Login: apgrucza
X-GitHub-Comment-Id: 1427431482
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 7944b46eabee8ff4b7d5a4867ff968f84da405b0
X-GitHub-Issue: 1
X-GitHub-Path: statement.c
X-GitHub-Repo: postgresql-interfaces/psqlodbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/pull/1#discussion_r1427431482
Content-Type: text/plain; charset=utf-8

(on statement.c)

This line was removed in https://github.com/postgresql-interfaces/psqlodbc/commit/f3d66715dc46d7faf67a9785159d382674de497d on purpose to fix a crash (due to destructing the same object twice) and should not be added back. `rhold.first` is destructed on line 2374 below.