Message-ID: <gh-postgresql-interfaces-psqlodbc-122-c2943550652@github.com>
From: "chrullrich (@chrullrich)" <noreply+chrullrich@github.com>
To: "postgresql-interfaces/psqlodbc" <noreply+postgresql-interfaces-psqlodbc@github.com>
Date: Thu, 05 Jun 2025 10:03:16 +0000
Subject: Re: [postgresql-interfaces/psqlodbc] issue #122: 17.00.0005 release showing version number of 17.00.0004
In-Reply-To: <gh-postgresql-interfaces-psqlodbc-122@github.com>
References: <gh-postgresql-interfaces-psqlodbc-122@github.com>
List-Id: <gh-postgresql-interfaces-psqlodbc.github.com>
X-GitHub-Author-Login: chrullrich
X-GitHub-Comment-Id: 2943550652
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2025-06-05T10:03:48Z
X-GitHub-Issue: 122
X-GitHub-Repo: postgresql-interfaces/psqlodbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/issues/122#issuecomment-2943550652
Content-Type: text/plain; charset=utf-8

It doesn't. The files are passed through unmodified, so the version resources have to be correct in them. WiX extracts the version number for its own purposes, too, but the way the installers work this does not prevent it from replacing the files with the new versions.

The display form of the version number did not update because 151feaa8080181a5ae0f9bc4d2211e5bd69e5539 replaced the macro POSTGRES_RESOURCE_VERSION in psqlodbc.rc with a literal "17.00.0004" in four places.

As to why the internal versions did not change even though psqlodbc.rc includes version.h, I currently have no idea. There may be something in the build procedure that did not get updated; version.h mentions that the versions may be overridden by command line arguments from psqlodbc.vcxproj, and it looks like that file uses the arguments. I have not yet found out where it takes their values from.