postgresql-interfaces/psqlodbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[postgresql-interfaces/psqlodbc] PR #13: Key caches based on software versions
6+ messages / 2 participants
[nested] [flat]

* [postgresql-interfaces/psqlodbc] PR #13: Key caches based on software versions
@ 2024-05-11 03:04 "apgrucza (@apgrucza)" <[email protected]>
  0 siblings, 0 replies; 6+ messages in thread

From: apgrucza (@apgrucza) @ 2024-05-11 03:04 UTC (permalink / raw)
  To: postgresql-interfaces/psqlodbc <[email protected]>

This fixes the problem of the cache action incorrectly causing steps to be skipped when software versions are updated.

Note that changing the commands inside a step will not prevent that step from being skipped, but this should not be a problem once the workflow is stable. If this does occur, it can be resolved by adding a suffix to the cache key to force the creation of a new cache.

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [postgresql-interfaces/psqlodbc] PR #13: Key caches based on software versions
@ 2024-05-11 11:47 ` "apgrucza (@apgrucza)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: apgrucza (@apgrucza) @ 2024-05-11 11:47 UTC (permalink / raw)
  To: postgresql-interfaces/psqlodbc <[email protected]>

The failed workflow was due to [this bug](https://github.com/actions/cache/issues/1385) in `actions/cache`. I've renamed the necessary cache key to work around it.

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [postgresql-interfaces/psqlodbc] PR #13: Key caches based on software versions
@ 2024-05-11 20:33 ` "davecramer (@davecramer)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: davecramer (@davecramer) @ 2024-05-11 20:33 UTC (permalink / raw)
  To: postgresql-interfaces/psqlodbc <[email protected]>

testing failed ?

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [postgresql-interfaces/psqlodbc] PR #13: Key caches based on software versions
@ 2024-05-11 21:46 ` "apgrucza (@apgrucza)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: apgrucza (@apgrucza) @ 2024-05-11 21:46 UTC (permalink / raw)
  To: postgresql-interfaces/psqlodbc <[email protected]>

> testing failed ?

See my comment above. Please rerun the workflow.

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [postgresql-interfaces/psqlodbc] PR #13: Key caches based on software versions
@ 2024-05-13 13:07 ` "davecramer (@davecramer)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: davecramer (@davecramer) @ 2024-05-13 13:07 UTC (permalink / raw)
  To: postgresql-interfaces/psqlodbc <[email protected]>

I noticed that you changed it so that we aren't downloading openssl64 anymore. 
We want to keep the versions of openssl the same so we need to download both 64 and 32 bit versions
EDB has version 3.0.13 of openssl

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [postgresql-interfaces/psqlodbc] PR #13: Key caches based on software versions
@ 2024-05-14 00:30 ` "apgrucza (@apgrucza)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: apgrucza (@apgrucza) @ 2024-05-14 00:30 UTC (permalink / raw)
  To: postgresql-interfaces/psqlodbc <[email protected]>

> I noticed that you changed it so that we aren't downloading openssl64 anymore. We want to keep the versions of openssl the same so we need to download both 64 and 32 bit versions EDB has version 3.0.13 of openssl

@davecramer Yes, I was expecting you to merge those changes from your fork, which I see you've now done. After your changes, the other caching problem I mentioned in the description of  #13 has occurred and prevented the build of PostgreSQL, resulting in missing DLLs again. So I've created a new PR to address that here: #19


^ permalink  raw  reply  [nested|flat] 6+ messages in thread

end of thread, other threads:[~2024-05-14 00:30 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-05-11 03:04 [postgresql-interfaces/psqlodbc] PR #13: Key caches based on software versions "apgrucza (@apgrucza)" <[email protected]>
2024-05-11 11:47 ` "apgrucza (@apgrucza)" <[email protected]>
2024-05-11 20:33 ` "davecramer (@davecramer)" <[email protected]>
2024-05-11 21:46 ` "apgrucza (@apgrucza)" <[email protected]>
2024-05-13 13:07 ` "davecramer (@davecramer)" <[email protected]>
2024-05-14 00:30 ` "apgrucza (@apgrucza)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox