postgresql-interfaces/psqlodbc GitHub issues and pull requests (mirror)  
help / color / mirror / Atom feed
From: jarvis24young (@jarvis24young) <[email protected]>
To: postgresql-interfaces/psqlodbc <[email protected]>
Subject: Re: [postgresql-interfaces/psqlodbc] PR #178: Reject overlong cursor names
Date: Tue, 28 Apr 2026 11:41:35 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Thanks for the review. I updated the regression test to also verify the diagnostic state for the rejected overlong cursor name. The test now builds the invalid name as SQL_MAX_CURSOR_NAME_LEN + 1, calls SQLGetDiagRec() after SQLSetCursorName() fails, and requires SQLSTATE 34000 before continuing with the existing valid cursor-name path.

Re-tested in WSL with the unixODBC black-box path and ASan/UBSan/gcov build:

```text
TAP version 13
1..1
ok 1 - cursor-name
```

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://postgresql-interfaces/psqlodbc
  Cc: [email protected], [email protected]
  Subject: Re: [postgresql-interfaces/psqlodbc] PR #178: Reject overlong cursor names
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox