Message-ID: <gh-postgresql-interfaces-psqlodbc-18-c2109900263@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "postgresql-interfaces/psqlodbc" <noreply+postgresql-interfaces-psqlodbc@github.com>
Date: Tue, 14 May 2024 10:57:10 +0000
Subject: Re: [postgresql-interfaces/psqlodbc] PR #18: Notes todo and attempt to fix memory leak
In-Reply-To: <gh-postgresql-interfaces-psqlodbc-18@github.com>
References: <gh-postgresql-interfaces-psqlodbc-18@github.com>
List-Id: <gh-postgresql-interfaces-psqlodbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 2109900263
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 18
X-GitHub-Repo: postgresql-interfaces/psqlodbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/pull/18#issuecomment-2109900263
Content-Type: text/plain; charset=utf-8

> This fix for memory leak is incorrect. It broke the meaning of `CC_clear_col_info` function - this function is clearing COL_INFO cache from `ConnectionClass` object, when it is obsolete, or connection is closing. Your fix will leave obsolete cache entries. To fix this leak correctly, we need to restore refcnt lifetime management. I have strong intent to do this, because these leaks causing fails with my project's unit tests. For now, i have another problem - many psqlodbc native tests are failing, saying that `testtab1` does not exist... (

Well I need to figure out how to test this.

As for `testtab1` why not use the existing tests ?