Message-ID: <gh-postgresql-interfaces-psqlodbc-183-c4410937648@github.com>
From: "jarvis24young (@jarvis24young)" <noreply+jarvis24young@github.com>
To: "postgresql-interfaces/psqlodbc" <noreply+postgresql-interfaces-psqlodbc@github.com>
Date: Sat, 09 May 2026 01:17:33 +0000
Subject: Re: [postgresql-interfaces/psqlodbc] PR #183: Detach freed app descriptors from statements
In-Reply-To: <gh-postgresql-interfaces-psqlodbc-183@github.com>
References: <gh-postgresql-interfaces-psqlodbc-183@github.com>
List-Id: <gh-postgresql-interfaces-psqlodbc.github.com>
X-GitHub-Author-Login: jarvis24young
X-GitHub-Comment-Id: 4410937648
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2026-05-09T01:17:57Z
X-GitHub-Issue: 183
X-GitHub-Repo: postgresql-interfaces/psqlodbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/pull/183#issuecomment-4410937648
Content-Type: text/plain; charset=utf-8

Thanks for the review.

The core detach logic is unchanged.

The Linux CI failure was caused by a missing expected output file for the new regression test. I have now added `test/expected/descriptors-free.out`, which matches the test stdout and lets `runsuite` execute the case instead of bailing out before comparison.

This keeps the patch focused on the lifetime fix in `PGAPI_FreeDesc()` / `CC_detach_descriptor()` and addresses the blocking issue raised by the pipeline.