Message-ID: <gh-postgresql-interfaces-psqlodbc-29@github.com>
From: "omeuid (@omeuid)" <noreply+omeuid@github.com>
To: "postgresql-interfaces/psqlodbc" <noreply+postgresql-interfaces-psqlodbc@github.com>
Date: Thu, 06 Jun 2024 16:35:19 +0000
Subject: [postgresql-interfaces/psqlodbc] issue #29: Possible issue in find_default_msbuild_path function from MSProgram-Get.psm1
List-Id: <gh-postgresql-interfaces-psqlodbc.github.com>
X-GitHub-Author-Id: 6940566
X-GitHub-Author-Login: omeuid
X-GitHub-Issue: 29
X-GitHub-Repo: postgresql-interfaces/psqlodbc
X-GitHub-State: closed
X-GitHub-Type: issue
X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/issues/29
Content-Type: text/plain; charset=utf-8

I understand that the find_default_msbuild_path function from the MSProgram-Get.psm1 script could be wrong.

I would change the condition from the following IF statement:

```
    if ($env:PROCESSOR_ARCHITECTURE -eq "x86" -or $env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
        $pgmfs = "$env:ProgramFiles"
    } else {
        $pgmfs = "${env:ProgramFiles(x86)}"
    }
```

As the objective seems to be the correct selection of the program files directory based on the processor architecture I would change the first line with the following one:
```
if ($env:PROCESSOR_ARCHITECTURE -eq "x64" -or $env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
```

Am I missing something or should that change be done?

Regards,
Carlos