Message-ID: <gh-postgresql-interfaces-psqlodbc-33-c2236039650@github.com>
From: "Hunaid2000 (@Hunaid2000)" <noreply+Hunaid2000@github.com>
To: "postgresql-interfaces/psqlodbc" <noreply+postgresql-interfaces-psqlodbc@github.com>
Date: Thu, 18 Jul 2024 09:23:50 +0000
Subject: Re: [postgresql-interfaces/psqlodbc] issue #33: SQLGetData function can return an incorrect SQLSTATE
In-Reply-To: <gh-postgresql-interfaces-psqlodbc-33@github.com>
References: <gh-postgresql-interfaces-psqlodbc-33@github.com>
List-Id: <gh-postgresql-interfaces-psqlodbc.github.com>
X-GitHub-Author-Login: Hunaid2000
X-GitHub-Comment-Id: 2236039650
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 33
X-GitHub-Repo: postgresql-interfaces/psqlodbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/issues/33#issuecomment-2236039650
Content-Type: text/plain; charset=utf-8

Yes, I agree with you. Actually in `PGAPI_GetData` function after `copy_and_convert_field` call that returns `SQL_ERROR` it goes in default case and overrides the error. So, `copy_and_convert_field` should return `COPY_GENERAL_ERROR`.

https://github.com/postgresql-interfaces/psqlodbc/blob/c5053678f09ac204816b7ca7d6624af0f4987e70/results.c#L1097-L1139