Message-ID: From: "apgrucza (@apgrucza)" To: "postgresql-interfaces/psqlodbc" Date: Wed, 01 May 2024 12:59:48 +0000 Subject: Re: [postgresql-interfaces/psqlodbc] PR #6: Use mimalloc to improve performance and reduce memory allocation lock contention In-Reply-To: References: List-Id: X-GitHub-Author-Login: apgrucza X-GitHub-Comment-Id: 2088429349 X-GitHub-Comment-Type: issue_comment X-GitHub-Issue: 6 X-GitHub-Repo: postgresql-interfaces/psqlodbc X-GitHub-Type: comment X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/pull/6#issuecomment-2088429349 Content-Type: text/plain; charset=utf-8 Another question. Was it a deliberate decision to use the latest version of Visual C++ (VC17) in the GitHub Actions? Looking at the build script, [the "official" version to build against is VC15](https://github.com/postgresql-interfaces/psqlodbc/blob/3869efe76653ce9e56edf10478e30dcf1072123c/winbuild/MSProgram-Get.psm1#L43) (it will use that version even if newer versions are installed). When VC16 was added to the build script, I think it was [for development purposes only](https://github.com/postgresql-interfaces/psqlodbc/blob/3869efe76653ce9e56edf10478e30dcf1072123c/docs/release.html#L77) (rather than for building releases). I'm not opposed to building against VC17, but the change should be documented as I believe it may require users to install a newer version of the Microsoft Visual C++ Redistributable. And [this page](https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#notes) suggests if psqlODBC required the VC17 runtime, it would no longer run on Windows XP: > The last version of the Visual C++ Redistributable that works on Windows XP shipped in Visual Studio 2019 version 16.7 (file versions starting with 14.27).