Message-ID: <gh-postgresql-interfaces-psqlodbc-6-c2090360711@github.com>
From: "apgrucza (@apgrucza)" <noreply+apgrucza@github.com>
To: "postgresql-interfaces/psqlodbc" <noreply+postgresql-interfaces-psqlodbc@github.com>
Date: Thu, 02 May 2024 12:19:30 +0000
Subject: Re: [postgresql-interfaces/psqlodbc] PR #6: Use mimalloc to improve performance and reduce memory allocation lock contention
In-Reply-To: <gh-postgresql-interfaces-psqlodbc-6@github.com>
References: <gh-postgresql-interfaces-psqlodbc-6@github.com>
List-Id: <gh-postgresql-interfaces-psqlodbc.github.com>
X-GitHub-Author-Login: apgrucza
X-GitHub-Comment-Id: 2090360711
X-GitHub-Comment-Type: issue_comment
X-GitHub-Edited-At: 2024-05-02T12:20:28Z
X-GitHub-Issue: 6
X-GitHub-Repo: postgresql-interfaces/psqlodbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/pull/6#issuecomment-2090360711
Content-Type: text/plain; charset=utf-8

And when I build the installer locally, all those extra libs are included in the MSI file.

I noticed `configuration.xml` in the GitHub workflow references the directories from your PostgreSQL build (`d:\postgresql86` and `d:\postgresql`) rather than the directory that the EDB installer creates. On my system I didn't have to build PostgreSQL. I just ran the EDB installer, which creates `C:\Program Files\PostgreSQL\16`, and then my `configuration.xml` simply references this directory:

```xml
    <libpq version="y">
      <include>C:\Program Files\PostgreSQL\16\include</include>
      <lib>C:\Program Files\PostgreSQL\16\lib</lib>
      <bin>C:\Program Files\PostgreSQL\16\bin</bin>
    </libpq>
```

Perhaps you should do the same in the GitHub workflow? You may need change the `--enable-components` option for the `include` directory to be created. Once you do this, I don't think you need the GitHub workflow to build PostgreSQL at all.

Not sure if this will fix the problem, but it's worth a try and should simplify the workflow too.