Message-ID: <gh-postgresql-interfaces-psqlodbc-6-c2093114745@github.com>
From: "apgrucza (@apgrucza)" <noreply+apgrucza@github.com>
To: "postgresql-interfaces/psqlodbc" <noreply+postgresql-interfaces-psqlodbc@github.com>
Date: Fri, 03 May 2024 14:16:27 +0000
Subject: Re: [postgresql-interfaces/psqlodbc] PR #6: Use mimalloc to improve performance and reduce memory allocation lock contention
In-Reply-To: <gh-postgresql-interfaces-psqlodbc-6@github.com>
References: <gh-postgresql-interfaces-psqlodbc-6@github.com>
List-Id: <gh-postgresql-interfaces-psqlodbc.github.com>
X-GitHub-Author-Login: apgrucza
X-GitHub-Comment-Id: 2093114745
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 6
X-GitHub-Repo: postgresql-interfaces/psqlodbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/pull/6#issuecomment-2093114745
Content-Type: text/plain; charset=utf-8

As a test, I updated `configuration.xml` in my fork to point to the EDB one (for x64):

```xml
  <x64>
    <libpq version="y">
      <include>C:\Program Files\PostgreSQL\16\include</include>
      <lib>C:\Program Files\PostgreSQL\16\lib</lib>
      <bin>C:\Program Files\PostgreSQL\16\bin</bin>
    </libpq>
    ...
```

This time the x64 MSI produced by the GitHub workflow included the extra DLLs (libcrypto, libssl, libiconv, libintl, libwinpthread) and installed successfully. But as you point out, EDB does not provide an x86 build for PostgreSQL 16.

I compared `d:\postgresql\lib` with `C:\Program Files\PostgreSQL\16\lib` and there were a lot of differences. The former was missing files such as `libcrypto.lib` and `libssl.lib`. Perhaps EDB have a different build process. Regardless, it's probably better to build a stable release from https://www.postgresql.org/ftp/source/ rather than from HEAD.