Message-ID: <gh-postgresql-interfaces-psqlodbc-64@github.com>
From: "chrullrich (@chrullrich)" <noreply+chrullrich@github.com>
To: "postgresql-interfaces/psqlodbc" <noreply+postgresql-interfaces-psqlodbc@github.com>
Date: Sat, 05 Oct 2024 17:08:51 +0000
Subject: [postgresql-interfaces/psqlodbc] PR #64: MSI improvements
List-Id: <gh-postgresql-interfaces-psqlodbc.github.com>
X-GitHub-Author-Id: 4695907
X-GitHub-Author-Login: chrullrich
X-GitHub-Issue: 64
X-GitHub-Repo: postgresql-interfaces/psqlodbc
X-GitHub-State: closed
X-GitHub-Type: pull_request
X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/pull/64
Content-Type: text/plain; charset=utf-8

This is the yield from ~8 hours of poring over the code. This is mostly janitorial stuff, but I'm by no means done; there is more to come. It would be great if you could look it over and tell me whether you are comfortable with it.

My claim in #57 that the component rules violation was the reason for the installation path not changing between versions was wrong. This is in fact an intentional behavior of Windows Installer as long as ODBC drivers are installed using the built-in support, i.e. the ODBCDriver table. In that case, the SetODBCFolders standard action overrides the installation path to maintain the driver in the same location.