Message-ID: <gh-postgresql-interfaces-psqlodbc-89-c2629549653@github.com>
From: "vadz (@vadz)" <noreply+vadz@github.com>
To: "postgresql-interfaces/psqlodbc" <noreply+postgresql-interfaces-psqlodbc@github.com>
Date: Sun, 02 Feb 2025 20:49:22 +0000
Subject: Re: [postgresql-interfaces/psqlodbc] issue #89: Batch update with some invalid values fails for all rows
In-Reply-To: <gh-postgresql-interfaces-psqlodbc-89@github.com>
References: <gh-postgresql-interfaces-psqlodbc-89@github.com>
List-Id: <gh-postgresql-interfaces-psqlodbc.github.com>
X-GitHub-Author-Login: vadz
X-GitHub-Comment-Id: 2629549653
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 89
X-GitHub-Repo: postgresql-interfaces/psqlodbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/postgresql-interfaces/psqlodbc/issues/89#issuecomment-2629549653
Content-Type: text/plain; charset=utf-8

> Can you show me the code you are thinking it is using.

I've been looking at the part of `PGAPI_Execute()` between https://github.com/postgresql-interfaces/psqlodbc/blob/1fbc3b2bd31c9719763cc5d232ac0c0ea5a02f71/execute.c#L1140 and https://github.com/postgresql-interfaces/psqlodbc/blob/1fbc3b2bd31c9719763cc5d232ac0c0ea5a02f71/execute.c#L1241-L1244 but I could easily be wrong as I mostly just looked at the label name. I probably should understand how to enable tracing in this code to see what it's really doing during tun-time...

> Without looking at the code I would think it does
>
> `insert into testtab1 (id) values (1),(2);`

Interesting, wouldn't this run into some kind of limitation (number of parameters or total length of the command) for even relatively small amounts of data?