Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gH5Br-0003Jp-LD for psycopg@arkaria.postgresql.org; Mon, 29 Oct 2018 10:54:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gH5Bp-00070E-OV for psycopg@arkaria.postgresql.org; Mon, 29 Oct 2018 10:54:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gH5Bp-000706-JV for psycopg@lists.postgresql.org; Mon, 29 Oct 2018 10:54:33 +0000 Received: from mout.gmx.net ([212.227.17.22]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gH5Bj-00033A-8g for psycopg@lists.postgresql.org; Mon, 29 Oct 2018 10:54:33 +0000 Received: from hermes ([84.165.106.202]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MGB7j-1gK5KB1UaF-00FAI2 for ; Mon, 29 Oct 2018 11:54:24 +0100 Received: from hermes ([84.165.106.202]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MGB7j-1gK5KB1UaF-00FAI2 for ; Mon, 29 Oct 2018 11:54:24 +0100 Received: from ncq by hermes with local (Exim 4.91) (envelope-from ) id 1gH5Be-0006zZ-KP for psycopg@lists.postgresql.org; Mon, 29 Oct 2018 11:54:22 +0100 Date: Mon, 29 Oct 2018 11:54:22 +0100 From: Karsten Hilbert To: psycopg@lists.postgresql.org Subject: Re: Feature branches merged to master for 2.8 release Message-ID: <20181029105422.GD2262@hermes.hilbert.loc> References: <1878453370.14916776.1539604797985@mail.yahoo.com> <62b46b76-ce7f-6b89-b5ad-d0f2c2533432@dndg.it> <1820701010.20861820.1540152265403@mail.yahoo.com> <1390677301.27162879.1540762541620@mail.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Ma_X_il-Followup-to: d Re_X_turn-receipt-to: Karsten.Hilbert@gmx.net Di_X_sposition-Notification-To: Karsten.Hilbert@gmx.net X-Confi_X_rm-Reading-To: Karsten.Hilbert@gmx.net X-Pri_X_ority: 2 (High) User-Agent: Mutt/1.10.1 (2018-07-13) Sender: X-Provags-ID: V03:K1:JVmwM87GFhrI6Q7hWGJ+06bnNKzsOzjlpuWX1eDPNFQBfb+zVg0 MwGRkScfIjTqlPpc1dzh9QLzxeZZbMt8pLwxM4L+BKVl79ySfu/SBVHManRTnrG33qe0Wii kl+cXhEZeCxgKRSObXZ+TrhBbCLxVlec8YxcqIhLj2OZgcSS62rQLnd1hhGVg43KJ1Z4vAH 6YsLVXWNj8aiQCDBx35Xw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:EbNMA5uvnmY=:oSmFzvLKo/mR4fzwKtkwnj MOD1kYE1nfBlLEQeZZSW7wDIoF8BjnRhJJI6F5ECFJ7aKTF/tWGu4kRwG/IvoFLimM1kLt1vg IU3OY642ckzPwLtBMvE3pVayV1Ev5vgVM6UsB9jkwfbsFWOceEcofn5cr/kvEBEffM5YuUwx6 wW0nelwp+PHRMt3umV2NZGqg5d0HgB5PN32qoRa0wZOlswvIRN9NKTg9FNh7xmVc4DVRXoC2w hRLixswpTJwy7kt7IiD9ZtraENaTk7+GkKkjMe5gUPj4HOdSMUwrUXgooYHw+XnR5YcyCcVWl TmhzWdwZ4cvc6zxcMUqyniqrlfphMv3V0p+VEfqFKXXYs/zPw9QbUM0EEVNnKCUDRm0KMfN8g zVG/5eDZiKACAoju2/TL6yN1pMzaadCX01PvqPpfrKfXnTugjGLzVki/ydgHIPfu+VymbQOkd yeBxT/+SQRxBvpVnX/epdezEXtPPvFxUHryciSeBTdo7rlyYRd6FHdhmrZT9OuMiL6eWFE+eg 2jt5nh+UD8u8cyzdezethkZ5fQzcnY43mmCGyZGXdnTHZJPSoCd2fMk528sFA4quu8wTo/q/8 qepH/xNK1wTF6GIXJOGqB2uyE4o74pTI/orFPxCJo8XH5SfcGAXmwrXoAd/EriFByHb1UPg7j hszle8yIip/I5oHWizyiuWk7fm+V+uk3KipF1nBubC9cicGMqNAdH9mSgr/smiuiRnX1X8iSJ Yz++/IiXGsGUQ5ZfpIIreXhb1n5qS1sZEZ67lK2wG1C8ZhQqS+kcxDm8DKlaGIWOzWyUQlNZW sWQbw2KmG6Hgt8bJij68Kkqa7WgXg== List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Mon, Oct 29, 2018 at 10:49:14AM +0000, Daniele Varrazzo wrote: > There are always differences, in interfaces and in behaviour, between > dbapi drivers. A private method, returning two objects which are > different because they are very simply two database drivers, are not > the place where to start trying to unify interfaces. What you do, if > you want to deal with both drivers, is to write a wrapper unifying the > interfaces. I would be ok to adapt other drivers choices, if I agreed > with them, but I can't agree with an underscore method being > documented as part of the API: that's internal stuff and totally not > idiomatic Python. > > My vote goes to have this method name without underscore, but I'll > leave the final decision to Federico. Apart from a wrapper class one can always monkey-patch my_dbapi_instance._get_native_connection = my_dbapi_instance.get_native_connection at runtime. Karsten -- GPG 40BE 5B0E C98E 1713 AFA6 5BC0 3BEA AC80 7D4F C89B