Date: Tue, 26 May 2020 14:08:01 +0100
From: Rory Campbell-Lange <rory@campbell-lange.net>
To: Frank Millman <frank@chagford.com>
Cc: psycopg@postgresql.org
Subject: Re: Minor issue
Message-ID: <20200526130801.GA23081@campbell-lange.net>
References: <92a25cd6-5b50-3074-0da6-7394db9e0f0a@chagford.com>
 <CA+mi_8YDBvXkns7odQQ5VLATyCXe2xFTw_KV5H19Q9aTyWEEog@mail.gmail.com>
 <3f076465-0e4f-ff6b-6a7b-51ba7daf3bc3@chagford.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3f076465-0e4f-ff6b-6a7b-51ba7daf3bc3@chagford.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 26/05/20, Frank Millman (frank@chagford.com) wrote:
> On 2020-05-26 2:11 PM, Daniele Varrazzo wrote:
> > No, we don't want to add any intelligence in trying to figure out what
> > is into a query. If you are comfortable that you will be using always
> > the same pattern for comments you can easily clean the string yourself
> > before passing it to psycopg.
> > 
> > A better approach for you I guess would be to use named placeholders,
> > so that an a missing placeholder wouldn't require you to change the
> > arguments to execute.

> Ok, thanks.
> 
> Frank

I must be missing something, because this works for me:

    In [28]: d.query("""
        ...: select 
        ...:     1 as a
        ...:     /*
        ...:     ,2 as b
        ...:     */
        ...:     -- ,'hi' as c
        ...:     ,%s as d
        ...: """, ("a string", )).results
    Out[28]: [Record(a=1, d='a string')]

(d.query is a wrapper around cursor_create, execute and fetchall).

Does using %s instead of {}.format help solve the issue?