Date: Tue, 26 May 2020 15:09:36 +0100
From: Rory Campbell-Lange <rory@campbell-lange.net>
To: Frank Millman <frank@chagford.com>
Cc: psycopg@postgresql.org
Subject: Re: Minor issue
Message-ID: <20200526140936.GA28120@campbell-lange.net>
References: <92a25cd6-5b50-3074-0da6-7394db9e0f0a@chagford.com>
 <CA+mi_8YDBvXkns7odQQ5VLATyCXe2xFTw_KV5H19Q9aTyWEEog@mail.gmail.com>
 <3f076465-0e4f-ff6b-6a7b-51ba7daf3bc3@chagford.com>
 <20200526130801.GA23081@campbell-lange.net>
 <cd80d720-4616-c409-dab2-ba835f706581@chagford.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cd80d720-4616-c409-dab2-ba835f706581@chagford.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 26/05/20, Frank Millman (frank@chagford.com) wrote:
> 
> 
> On 2020-05-26 3:08 PM, Rory Campbell-Lange wrote:
> > On 26/05/20, Frank Millman (frank@chagford.com) wrote:
> > Does using %s instead of {}.format help solve the issue?
> 
> To reproduce my situation, you should place the '--' at the beginning of the
> following line (',%s as d').
> 
> As no parameters are now being substituted, I would expect to supply an
> empty tuple. In fact, the parameter is still required.

That makes sense, apologies.

However, this works as you suggest:

	In [33]: d.query("""
		...: select 
		...:     1 as a
		...:     /*
		...:     ,2 as b
		...:     */
		...:     -- ,'hi' as c
		...:     -- ,%s as d
		...: """, ("a string", )).results
	Out[33]: [Record(a=1)]

This doesn't work (as you suggest):

	In [35]: d.query("""
		...: select 
		...:     1 as a
		...:     /*
		...:     ,2 as b
		...:     */
		...:     -- ,'hi' as c
		...:     -- ,%s as d
		...: """, ()).results
	ERROR:root:An unexpected error occurred while tokenizing input
	The following traceback may be corrupted or invalid
	The error message is: ('EOF in multi-line string', (1, 0))

But this works:

	In [34]: d.query("""
		...: select 
		...:     1 as a
		...:     /*
		...:     ,2 as b
		...:     */
		...:     -- ,'hi' as c
		...:     -- ,%s as d
		...: """).results
	Out[34]: [Record(a=1)]

So perhaps simply don't provide the tuple in this case? This will also probably
work for your other backends.

Rory